chore(cloud-native): adjust resource scope mappings#2542
Conversation
Signed-off-by: iromli <isman.firmansyah@gmail.com>
📝 WalkthroughWalkthroughThis pull request updates Docker image source version pins for the Jans and Flex repositories, and adds a new migration method to automatically update resource scope mappings for the admin UI from deprecated names to new ones. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: iromli <isman.firmansyah@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
docker-admin-ui/Dockerfiledocker-admin-ui/scripts/upgrade.pydocker-flex-all-in-one/Dockerfile
🧰 Additional context used
🪛 GitHub Actions: Scan Image
docker-flex-all-in-one/Dockerfile
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_AUTH_JAVA_OPTIONS")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_AUTH_JETTY_HOST")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_AUTH_JETTY_PORT")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SHARE_AUTH_CONF")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SQL_PASSWORD_FILE")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SAML_KC_ADMIN_CREDENTIALS_FILE")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SAML_KC_DB_PASSWORD_FILE")
docker-admin-ui/Dockerfile
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_AUTH_JAVA_OPTIONS")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_AUTH_JETTY_HOST")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_AUTH_JETTY_PORT")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SHARE_AUTH_CONF")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SQL_PASSWORD_FILE")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SAML_KC_ADMIN_CREDENTIALS_FILE")
[warning] 117-117: SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CN_SAML_KC_DB_PASSWORD_FILE")
🪛 Ruff (0.14.10)
docker-admin-ui/scripts/upgrade.py
242-242: Missing return type annotation for private function update_scope
Add return type annotation: None
(ANN202)
🔇 Additional comments (1)
docker-admin-ui/scripts/upgrade.py (1)
57-57: LGTM!The method invocation is appropriately placed in the upgrade flow, ensuring resource scope mappings are updated after client configurations.
|



The changeset adjusts the scope names required by admin-ui.
Closes #2541
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.