-
Notifications
You must be signed in to change notification settings - Fork 21
Convert Auth Server Properties into Forms along with Back button uniformity #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 54 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
4876bc1
fix(admin-ui): service status shows accurate values on dashboard inst…
faisalsiddique4400 1645e8b
merged with main
faisalsiddique4400 0f7d375
Merge branch 'main' of github-faisal:GluuFederation/flex into admin-u…
faisalsiddique4400 4f6653d
feat(admin-ui): update Config API configuration screen with recent ch…
faisalsiddique4400 8b97ae7
Merge branch 'main' of github-faisal:GluuFederation/flex into admin-u…
faisalsiddique4400 223e64b
coderabbit suggestions
faisalsiddique4400 80239a9
coderabbit suggestions
faisalsiddique4400 94dc763
coderabbit suggestions
faisalsiddique4400 dfec8a8
coderabbit suggestions
faisalsiddique4400 0a279c9
coderabbit suggestions
faisalsiddique4400 50cf5bd
coderabbit suggestions
faisalsiddique4400 5242d4c
feat(admin-ui): convert Config API Properties to forms with back butt…
faisalsiddique4400 fde6886
Merge branch 'main' into admin-ui-issue-2559
faisalsiddique4400 1e3a165
enhancement
faisalsiddique4400 55c0e8a
Merge branch 'main' of github-faisal:GluuFederation/flex into admin-u…
faisalsiddique4400 d7d2117
enhancement
faisalsiddique4400 9aeff7b
Merge branch 'main' of github-faisal:GluuFederation/flex into admin-u…
faisalsiddique4400 96cae73
Merge branch 'main' of github-faisal:GluuFederation/flex into admin-u…
faisalsiddique4400 3a2a443
Merge branch 'admin-ui-issue-2559' of github-faisal:GluuFederation/fl…
faisalsiddique4400 c357401
enhancement
faisalsiddique4400 58275c0
enhancement
faisalsiddique4400 e43e456
enhancement
faisalsiddique4400 45f03d6
enhancement
faisalsiddique4400 5a374db
enhancement
faisalsiddique4400 d413bb5
enhancement
faisalsiddique4400 92905c2
enhancement
faisalsiddique4400 baa24cf
enhancement
faisalsiddique4400 4696122
Merge branch 'admin-ui-issue-2559' of github-faisal:GluuFederation/fl…
faisalsiddique4400 b0a8ce8
feat(admin-ui): convert Auth Server Properties to forms with back but…
faisalsiddique4400 fe01fce
feat(admin-ui): Resolve conflicts coming in the pr
faisalsiddique4400 c72fae0
feat(admin-ui): Resolve issues coming in the pr
faisalsiddique4400 6bee2b7
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 49b972f
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 0418758
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 fa6083d
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 1d27aa0
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 9a375cc
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 39897e3
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 3010122
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 669a04e
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 37db9fa
feat(admin-ui): Resolve comments in the pr
faisalsiddique4400 a55b980
Merge branch 'main' of github-faisal:GluuFederation/flex into admin-u…
faisalsiddique4400 e80e454
Merge branch 'main' into admin-ui-issue-2560
faisalsiddique4400 187f88f
Merge branch 'admin-ui-issue-2560' of github-faisal:GluuFederation/fl…
faisalsiddique4400 e3bd943
Merge branch 'main' into admin-ui-issue-2560
faisalsiddique4400 7fb1f05
feat(admin-ui): Resolve comments on the pr
faisalsiddique4400 263f101
Merge branch 'admin-ui-issue-2560' of github-faisal:GluuFederation/fl…
faisalsiddique4400 e4f4162
feat(admin-ui): Resolve comments on the pr
faisalsiddique4400 1369612
feat(admin-ui): Resolve comments on the pr
faisalsiddique4400 67f3a36
feat(admin-ui): Resolve comments on the pr
faisalsiddique4400 f4af3ba
feat(admin-ui): Resolve comments on the pr
faisalsiddique4400 45eeb0b
Merge branch 'main' into admin-ui-issue-2560
faisalsiddique4400 c124fe6
Merge branch 'main' into admin-ui-issue-2560
faisalsiddique4400 14d182e
Merge branch 'main' into admin-ui-issue-2560
faisalsiddique4400 6cd9311
Merge branch 'main' into admin-ui-issue-2560
moabu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider consolidating with existing
validationssection.There's already a
validationssection (lines 1865-1889) in this file with overlapping keys likeinvalid_email,invalid_number,invalid_json, andfield_required. This creates duplication:validation_messages)validations)required_fieldfield_requiredinvalid_numberinvalid_numberinvalid_emailinvalid_emailinvalid_jsoninvalid_jsoninvalid_url_formatinvalid_urlConsider reusing the existing
validationsnamespace to avoid maintaining duplicate translations, or document why both namespaces are needed (e.g., different consumers).🤖 Prompt for AI Agents