Added tests to character package #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request primarily adds a comprehensive suite of tests for various features in the characters package and refactors some utility functions for improved clarity and maintenance.
- Added tests for worn items, shop operations, mob masteries, formatted names, cooldown mechanics, charm information, character behavior, and alignment conversion.
- Refactored several functions to use built-in slices and maps utilities (e.g., slices.Delete, maps.Copy, slices.Contains), and simplified some arithmetic expressions.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/characters/worn_test.go | Added tests for verifying the behavior of Worn methods. |
| internal/characters/shop_test.go | Introduced tests for Shop operations like stocking, destocking, and instock. |
| internal/characters/shop.go | Updated destocking logic to use slices.Delete for list element removal. |
| internal/characters/mobmastery_test.go | Added tests for mob mastery getters and setters. |
| internal/characters/formattedname_test.go | Added tests for adjective formatting functions. |
| internal/characters/cooldowns_test.go | Added tests covering cooldown decrementing and pruning behaviors. |
| internal/characters/cooldowns.go | Simplified loop syntax in RoundTick by iterating directly over key values. |
| internal/characters/charminfo_test.go | Added tests for charm creation and expiration. |
| internal/characters/character.go | Refactored multiple functions to utilize built-in maps/slices utilities. |
| internal/characters/alignment_test.go | Added tests for alignment-to-string conversion across different boundaries. |
Jasrags
changed the title
Volte6
approved these changes
May 21, 2025
Member
Volte6
left a comment
Volte6
left a comment
There was a problem hiding this comment.
Good cleanup as well (maps/slices).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expanded the test coverage of the character package to 24.3%, focused on functions that were simple to generate tests on.