Add support for Enhanced Security Direct Connection#212
Draft
Conversation
Res260
changed the title
xshill
reviewed
Dec 23, 2020
pyrdp/layer/tcp.py
Outdated
| TCP observers are notified when a connection is made. | ||
| """ | ||
|
|
||
| def __init__(self, config: MITMConfig): |
Collaborator
There was a problem hiding this comment.
Pretty sure you can just put quotes around the class name to avoid importing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a DRAFT pull request that modifies PyRDP to support the direct connection approach outlined in 1.3.1.2 Security-Enhanced Connection Sequence.
I think it still needs some work because it relies on private Twisted APIs (Unavoidable?) and propagates the MITM config into non-MITM modules, which feels unclean.
I would like to also refactor the MITM Config to split the MITM specific settings and the Core settings. This could also plug into the
.iniconfiguration files while we're playing in that code area.I'm opening the PR now in case someone has time (and wants) to work on it.