Skip to content

Conversation

@exploide
Copy link
Contributor

Prior to this PR, pyrdp is not compatible with Python 3.13.

  • changed deprecated import to typing.BinaryIO (which is backwards compatible even with Python 3.7)
  • fixed invalid escape sequence warnings by using raw-strings

fixes #486

@Res260 could you take a look?

@Res260
Copy link
Collaborator

Res260 commented Feb 24, 2025

Hey, could you please modify

  • .github/workflows/ci.yml line 39 and 109 to use python 3.13 as well as 3.12
  • .github/workflows/wheels.yml to use upload-artifacts@v4 instead of @V3 (this is unrelated to your PR, but makes two CI checks fail)

- changed deprecated import to typing.BinaryIO (which is backwards compatible)
- fixed invalid escape sequence warnings by using raw-strings

fixes #486
@exploide
Copy link
Contributor Author

Thank you very much for taking care of this PR @Res260 !

.github/workflows/ci.yml line 39 and 109 to use python 3.13 as well as 3.12

Done, though I don't know why testing against 3.12 should be kept. But I did the change anyway.

.github/workflows/wheels.yml to use upload-artifacts@v4 instead of @V3 (this is unrelated to your PR, but makes two CI checks fail)

Done, but I'm not sure if it will immediately succeed since the workflow does not run automatically. According to the migration guide changes might be required. Not sure if they are necessary here because the artifact is not named explicitly.

@exploide
Copy link
Contributor Author

Indeed, it was necessary to update the upload-artifacts@v4 usage as well, now it seems to work.

Besides, it was necessary to update the dependency on av, since older versions did no longer build on recent systems. See also #485.

Almost everything seems to work now. I'm not sure why the macOS build isn't running.

@Res260 Res260 merged commit 6030556 into GoSecure:main Feb 25, 2025
12 of 13 checks passed
@exploide exploide deleted the python-3.13 branch February 27, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.13 incompatibility due to usage of typing.io

2 participants