Fix: GitHub Workflows [Windows]#313
Closed
AtlasRW wants to merge 4 commits intoGodotECS:mainfrom
AtlasRW:main
Closed
Fix: GitHub Workflows [Windows]#313AtlasRW wants to merge 4 commits intoGodotECS:mainfrom AtlasRW:main
AtlasRW wants to merge 4 commits intoGodotECS:mainfrom
AtlasRW:main
Conversation
Member
|
The rationale to have the workflow running on every branch (also PRs) is to ensure everything works before merging a PR. With this change the workflow will run only for the main branch which is not the way it should work because we would catch errors way late. |
Author
|
Yes of course, I adapted the workflows to work on every push to any branch, just without the unnecessary cron jobs because as stated in the current state of the PR it already runs on every push on every branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the scheduled cron jobs from GitHub workflows so that they don't keep running forever for nothing
Also fixed the GitHub workflow for Windows builds
Tried the same for Linux builds and tried to config macOS builds but too much unexpected behaviors and as the
Compilepage in the wiki is blocked I've tried to fix it anyway and failed