Skip to content

Conversation

@mubinulhaque
Copy link

@mubinulhaque mubinulhaque commented Dec 13, 2025

In accordance with style guide given here:

  • Remove space between variable names and colons
  • Replace exclamation mark with not keyword
  • Add static typing to functions _on_body_entered() and _on_body_exited()

Disclaimer

No generative AI was used to enhance or create the code given here.

@BastiaanOlij
Copy link
Member

Sorry for not looking at this sooner. Happy with the changes (and in general with the other PRs as well). Only thing I wouldn't do is remove the lines between the extends and the class documentation. I think having the class documentation separated makes it easier to read.

@BastiaanOlij
Copy link
Member

(though I get the style guide states differently, one of the few things I don't like personally :) )

@BastiaanOlij BastiaanOlij added the cleanup Cleaning up code or aligning Godot 3 and 4 versions label Dec 27, 2025
@BastiaanOlij BastiaanOlij added this to the 4.6.0 milestone Dec 27, 2025
@mubinulhaque mubinulhaque force-pushed the area_audio_static_typing branch from dceecd1 to b009a75 Compare January 21, 2026 17:07
@mubinulhaque
Copy link
Author

mubinulhaque commented Jan 21, 2026

Done! Re-added space after extends, and removed documentation comment for private methods. Also replaced exclamation mark with not keyword. Don't know how I missed that the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleaning up code or aligning Godot 3 and 4 versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants