Skip to content

Better format and static type Vignette#786

Merged
BastiaanOlij merged 1 commit intoGodotVR:masterfrom
mubinulhaque:vignette_formatting
Mar 2, 2026
Merged

Better format and static type Vignette#786
BastiaanOlij merged 1 commit intoGodotVR:masterfrom
mubinulhaque:vignette_formatting

Conversation

@mubinulhaque
Copy link
Contributor

In accordance with style guide given here:

  • Add doc comments to variables and functions where possible
  • Replace exclamation marks with not keyword
  • Format multiline statements for more readability
  • Add variable for MeshInstance3D child
  • Add spaces before and after operations and equals signs
  • Add comments to export variables for better clarity
  • Remove spaces between colons and variable names
  • Specify types of variables for clarity

Disclaimer

No generative AI was used to enhance or create the code given here.

@BastiaanOlij BastiaanOlij added the cleanup Cleaning up code or aligning Godot 3 and 4 versions label Mar 1, 2026
@BastiaanOlij BastiaanOlij added this to the 4.6.0 milestone Mar 1, 2026
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BastiaanOlij BastiaanOlij merged commit bc895d9 into GodotVR:master Mar 2, 2026
2 checks passed
@BastiaanOlij
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleaning up code or aligning Godot 3 and 4 versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants