Fix an error expanding arguments for overridden methods in C++.#43
Open
toojays wants to merge 1 commit intoGolevka:masterfrom
Open
Fix an error expanding arguments for overridden methods in C++.#43toojays wants to merge 1 commit intoGolevka:masterfrom
toojays wants to merge 1 commit intoGolevka:masterfrom
Conversation
When returning a completion for a method which is implemented in a base class, the name of the class where the method was declared is included, so that instead of: COMPLETION: what : [#const char *#]what() const we receive: COMPLETION: what : [#const char *#]Implementation::what() const The extra semi-colons after the class name caused this completion to match a regexp which was added in hara/auto-complete-clang@4939442 (and merged in Golevka/emacs-clang-complete-async@3176ea3) to support Objective C. In this case, the argument list in the above example would be determined to be ":what() const" rather than just "()". This commit fixes the issue by avoiding that regexp unless we are in Objective C mode. This fixes Golevka#39.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When returning a completion for a method which is implemented in a base class,
the name of the class where the method was declared is included, so that instead
of:
COMPLETION: what : [#const char *#]what() const
we receive:
COMPLETION: what : [#const char *#]Implementation::what() const
The extra semi-colons after the class name caused this completion to match a
regexp which was added in hara/auto-complete-clang@4939442 (and merged in
3176ea3) to support Objective C. In this
case, the argument list in the above example would be determined to be ":what()
const" rather than just "()". This commit fixes the issue by avoiding that
regexp unless we are in Objective C mode.
This fixes #39.