Fix Definition.CoercibleType raising ArgumentError

.github/workflows/actions.yml

@@ -3,9 +3,9 @@ name: actions
 
 on:
   push:
-    branches: [ main, master ]
+    branches: [main, master]
   pull_request:
-    branches: [ main, master ]
+    branches: [main, master]
 
 permissions:
   contents: read
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ["2.7", "3.0", "3.1", "3.2", "3.3", "jruby-9.3", "jruby-9.4"]
+        ruby-version: ["2.7", "3.0", "3.1", "3.2", "3.3", "jruby-9.4"]
     steps:
       - uses: actions/checkout@v3
       - uses: ruby/setup-ruby@v1
@@ -25,4 +25,4 @@ jobs:
           bundler-cache: false
       - run: bundle install
       - run: bundle exec rspec
-      - run: bundle exec rubocop
+      - run: bundle exec rubocop

Changelog.md

@@ -1,100 +1,153 @@
 # Changelog
+
 All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## Unreleased
 
+## [1.1.3] - 2025-10-27
+
+### Fixed
+
+- Fixed TypeError when using Definition.CoercibleType with certain non coercible values
+
 ## [1.1.2] - 2024-08-22
+
 ### Fixed
-- Fixed "TypeError: no _dump_data is defined for class Proc" error that ocurred when a definition model inherits from another model that uses lambda based definitions
+
+- Fixed "TypeError: no \_dump_data is defined for class Proc" error that ocurred when a definition model inherits from another model that uses lambda based definitions
 
 ## [1.1.1] - 2024-05-21
+
 ### Fixed
+
 - Fixed Definition::Model inheritance
 
 ## [1.1.0] - 2023-11-22
+
 ### Changes
+
 - Improved performance
 
 ## [1.0.0] - 2023-02-14
+
 ### Removed
+
 - Removed deprecated version of `GreaterThanEqual` definition that had a typo in it (GreaterThenEqual)
 - Removed deprecated version of `GreaterThan` definition that had a typo in it (GreaterThen)
 - Removed deprecated version of `LessThanEqual` definition that had a typo in it (LessThenEqual)
 - Removed deprecated version of `LessThan` definition that had a typo in it (LessThen)
 
 ## [0.8.1] - 2022-10-05
+
 ### Fixed
+
 - Definition::Model#eql? returns true when comparing two models with the same content
 
 ## [0.8.0] - 2022-10-05
+
 ### Added
+
 - A Definition::Initializer mixin that can be used to validate keyword arguments of a class constructor
 
 ### Changes
+
 - Include more information in the internal non-translated error messages. E.g. the max size of a LessThenEqual definition
 - Renamed GreaterThen, GreaterThenEqual, LessThen and LessThenEqual to fix typo (Then VS Than) Backwards compatibility is ensured
 
 ### Breaking changes
+
 - The Definition::ValueObject was removed and replaced by Definition:Model which has a nicer DSL and only works with hash data structures. See [upgrade notes](./UpgradeNotes.md)
 
 ## [0.7.1] - 2022-03-04
+
 ### Fixed
+
 - Float coercion: check for nil before coercion
 
 ## [0.7.0] - 2022-02-25
+
 ### Added
+
 - Lambda definitions can now be failed with custom error messages
 - Compatibility with Ruby 3.0
+
 ### Fixed
+
 - In some cases errors from nested `Keys` definitions inside `Or` definitions got lost when listing the validation errors via the `error_hash` method on the conform result object.
+
 ### Changed
+
 - When no sub-definition of an `Or` conforms, then only the errors of the last definition of the `Or` are collected. Previously the errors of all sub-definitions were collected.
 - Translated error messages have been improved to be more suitable to be used as end user error messages
 
 ## [0.6.1] - 2021-12-14
+
 ### Fixed
+
 - The `Keys` definition crashed with an error if the input was not a Hash
 
 ## [0.6.0] - 2020-03-21
+
 ### Added
+
 - Added include method to Keys Definition that allows to inline other `Keys` Definitions into each other
 
 ## [0.5.2] - 2019-06-03
+
 ### Fixed
+
 - added missing require for "pathname"
 
 ## [0.5.1] - 2019-04-27
+
 ### Fixed
+
 - Typo in error debug output
 
 ## [0.5.0] - 2019-03-28
+
 ### Added
+
 - CoercibleValueObject Definition for better nesting of ValueObjects
 - Nilable Definition as shortcut for nil OR some other definition
 - Option for Keys Definition to ignore unexpected keys
+
 ### Fixed
+
 - Error hash was missing some errors in a few cases
 - `ConformResult.error_hash` was empty for Definitions without any `Keys` Definition
+
 ### Changed
+
 - And Definition stops processing after the first failure
 
 ## [0.4.0] - 2019-03-22
+
 ### Added
+
 - Added support for default values to Keys Definition
+
 ### Changed
+
 - Errors returned from ConformResult were restructured for better debugging and usage
 
 ## [0.3.0] - 2019-02-03
+
 ### Added
+
 - Added I18n translation support for errors
 
 ## [0.2.0] - 2019-01-13
+
 ### Added
+
 - Added built in definitions for common usecases (e.g. string length validation)
 
 ## [0.1.0] - 2019-01-12
+
 ### Added
+
 - Initial release

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    definition (1.1.2)
+    definition (1.1.3)
       activesupport
       i18n
 

lib/definition/dsl.rb

@@ -42,7 +42,7 @@ def CoercibleType(klass) # rubocop:disable Naming/MethodName
       end
       Types::Type.new(:type, klass) do |value|
         method(klass.name).call(value)
-      rescue ArgumentError
+      rescue ArgumentError, TypeError
         value
       end
     end

lib/definition/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Definition
-  VERSION = "1.1.2"
+  VERSION = "1.1.3"
 end

spec/approvals/definitioncoercibletype/with_incoercible_error_class_instance/behaves_like_it_does_not_conform/has_correct_error_hash.approved.json

@@ -0,0 +1,3 @@
+{
+  "": "<Definition::ConformError \n\t message: \"Is of type StandardError instead of Float\", \n\t json_pointer: \"/\">"
+}

spec/approvals/definitioncoercibletype/with_incoercible_error_class_instance/behaves_like_it_does_not_conform/has_correct_error_message.approved.txt

@@ -0,0 +1 @@
+Is of type StandardError instead of Float

spec/approvals/definitioncoercibletype/with_incoercible_error_class_instance/behaves_like_it_does_not_conform/has_correct_errors.approved.txt

@@ -0,0 +1,3 @@
+[0] <Definition::ConformError 
+	 message: "Is of type StandardError instead of Float", 
+	 json_pointer: "/">

spec/integration/coercible_type_spec.rb

@@ -21,4 +21,10 @@
 
     it_behaves_like "it does not conform"
   end
+
+  context "with incoercible error class instance" do
+    let(:value) { StandardError.new("oops") }
+
+    it_behaves_like "it does not conform"
+  end
 end