feat(upgrade): Update robyn to 3.12 #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danearley
approved these changes
Mar 18, 2025
danearley
left a comment
danearley
left a comment
There was a problem hiding this comment.
Since these are just changes from the Robyn upgrade and you were able to successfully produce the future_prophet, I'm giving it the ol' LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating Robyn to 3.12 but trying to keep the prophet outputs.
I was able to successfully output a
prophet_future.csvwith the 3.12 versionNext step is to update the client templates (the parse_init stuff)
(Merging will happen after all the client templates are updated)
Related Ticket
DS-2453