Adapt caching behaviour for dark/light theme switching

[khmyznikov]

Trying to address this bug

[khmyznikov]

@uwolfer is it looks like a fix?

[khmyznikov]

@PEConn @andreban how to check build?

[andreban]

Hey Gleb, thank you for the PR!

Would you mind adding how this change is solving #461 to the PR description? I also dropped a comment with regards moving magic values to static variables.

[khmyznikov]

@andreban from my understanding, it solves the issue of wrong caching of different icons for light/dark splash screen. #51 (comment)

[andreban]

Thanks for the update! What I'm making sure I understand is how this PR solves the issue - my understanding is that the bug is caused by only re-transferring the splash image file when the application is updated. But it also needs to be transferred when the theme changes. To solve that, you're adding the theme to the default preferences object, retrieving the value on launch, and ensuring the existing file is only re-used if all the following are true: the file exists, the app hasn't been updated, and the theme wasn't change. Does this sound right?

[khmyznikov]

@andreban yeah that's sounds right 👍

[andreban]

LGTM - Will wait for @PEConn to take a look before merging.

[uwolfer]

@uwolfer is it looks like a fix?

Thanks for working on this, @khmyznikov. Code makes sense to me, but I have not tested it. I would suggest that you update the PR title to reflect what we actually have fixed with this change.

[uwolfer]

@khmyznikov Do you think we can make progress on this PR?

[khmyznikov]

@uwolfer sure, I've updated the branch 👍