Fix chrome-out.log and chrome-err.log keep opening after browser closed#317
Open
datnv9 wants to merge 4 commits intoGoogleChrome:mainfrom
Open
Fix chrome-out.log and chrome-err.log keep opening after browser closed#317datnv9 wants to merge 4 commits intoGoogleChrome:mainfrom
datnv9 wants to merge 4 commits intoGoogleChrome:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
paulirish
approved these changes
May 6, 2025
paulirish
requested changes
May 6, 2025
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
the changes in destroyTmp() make complete sense. but i'm unsure about the event listener. do you know whats going on there?
| } | ||
|
|
||
| // handle process closed right after it started | ||
| this.chromeProcess.on('close', () => { |
Member
There was a problem hiding this comment.
this change fails some of the tests. not sure why at the moment.
But it may need to move slightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chrome-out.log and chrome-err.log keep opening after close browser windows
need to handle process.on('close') event right after it started and close opening file no matter what userdatadir is defined or not