Skip to content

fix: error when customize chrome path in wsl #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canstand wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: error when customize chrome path in wsl #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/chrome-launcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ const instances = new Set<Launcher>();

type JSONLike =|{[property: string]: JSONLike}|readonly JSONLike[]|string|number|boolean|null;

const windowsExePathRegex = /\.exe$/i;
const windowsMountPathRegex = /^\/mnt\/[a-z]\//i;

function isWindowsChromePath(chromePath: string | undefined) {
if (!chromePath) {
return false;
}
return windowsExePathRegex.test(chromePath) || windowsMountPathRegex.test(chromePath);
}

export interface Options {
startingUrl?: string;
chromeFlags?: Array<string>;
Expand Down Expand Up @@ -194,8 +204,8 @@ class Launcher {

if (!this.useDefaultProfile) {
// Place Chrome profile in a custom location we'll rm -rf later
// If in WSL, we need to use the Windows format
flags.push(`--user-data-dir=${isWsl ? toWin32Path(this.userDataDir) : this.userDataDir}`);
// If in WSL and using Windows Chrome binary, we need to use the Windows format
flags.push(`--user-data-dir=${isWsl && isWindowsChromePath(this.chromePath) ? toWin32Path(this.userDataDir) : this.userDataDir}`);
}

if (process.env.HEADLESS) flags.push('--headless');
Expand Down