-
Notifications
You must be signed in to change notification settings - Fork 482
Make WPT coverage analysis visible for Googlers and Chromium users (do not merge yet) #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think it's best to not land this change until December, when I can babysit things a little more. 🙂 |
jrobbins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks good. But, I'll hold off approving it for now because I agree with your plan to wait until December.
|
Did you mean to have this merging into your other branch instead of main? |
These changes are built off of other changes that haven't yet landed, so updating the merge target makes it so the PR view is isolated to only changes in this PR (for hopefully easier review) 🙂 Once the other PRs get merged in, the merge target here will change to main as it should |
95e9dc5 to
18f5d24
Compare
d373452 to
7fd21c9
Compare
5f04e15 to
a40bccd
Compare
7fd21c9 to
7ce3e08
Compare
|
Looking at the number of Googlers are on the roadmap page for m145 using their Chromium accounts, I'm wondering if it would be a better choice to make this available to Chromium email accounts as well. We have items in place to avoid overuse here (e.g. the 30 minute cooldown to regenerate the report, etc.). It might increase the velocity of feedback we get for this new feature 🤔 Edit: It is probably best to address #5922 before doing this. |
|
This should be okay to review and land. Some polishing PRs are in flight, but will also be deployed at the same time. |
|
(This needs Playwright snapshots update, which are being generated now) |
97e0024 to
d1796e2
Compare
d1796e2 to
a814f1e
Compare
This will allow us to get some feedback on this feature without initially making it visible to non-Googlers.