Skip to content

Conversation

@pranjalisr
Copy link
Contributor

@pranjalisr pranjalisr commented Jan 4, 2026

Added margin-bottom for all sidebar link items. For bug issue #5813

Introduced consistent vertical spacing for Roadmap sidebar navigation by applying a flex column layout with a gap, using existing spacing tokens.
This ensures uniform spacing between all navigation links and prevents the active item from collapsing spacing.

Implementation Details

Scoped the change to .roadmap-sidebar nav
Used gap instead of margins to avoid margin-collapse issues
Reused existing design tokens for spacing consistency
No DOM or JavaScript changes

Impact

Improves readability and visual hierarchy of sidebar navigation
Fixes spacing inconsistency for the active item
Visual-only change with low risk of regression

@google-cla
Copy link

google-cla bot commented Jan 4, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jrobbins
Copy link
Collaborator

jrobbins commented Jan 6, 2026

I don't see the original problem that you described and I don't see any visual difference between this PR and the layout. However, using flex and gap does seem likely to be more consistent for the future. I'm willing to approve and merge this change, but first you need to sign the CLA (see the automated comment earlier on this PR).

@pranjalisr
Copy link
Contributor Author

I don't see the original problem that you described and I don't see any visual difference between this PR and the layout. However, using flex and gap does seem likely to be more consistent for the future. I'm willing to approve and merge this change, but first you need to sign the CLA (see the automated comment earlier on this PR).

Thanks for the review!
I’ve now signed the CLA and completed all the required steps. Please let me know if there’s anything else needed from my side.
Appreciate your willingness to approve and merge the change — thanks!

@jrobbins jrobbins enabled auto-merge January 7, 2026 23:39
@jrobbins jrobbins added this pull request to the merge queue Jan 7, 2026
Merged via the queue into GoogleChrome:main with commit b58c3f8 Jan 7, 2026
8 checks passed
@jrobbins jrobbins mentioned this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants