Use defensive coding when converting Amendment to OpenAPI. #5825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRyanSmith
approved these changes
Jan 6, 2026
Collaborator
DanielRyanSmith
left a comment
DanielRyanSmith
left a comment
There was a problem hiding this comment.
Thanks for finding a fix here 🙂
jrobbins
deleted the
20260105-defensive-coding-for-amendment-conversion
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address an error seen on staging just now.
Somehow we got an Amendment object stored in NDB that had a
nullfor the new_value, so we can't assume it is a string.