Skip to content

Allow editing of first_notification_milestone for current release.#6127

Merged
jrobbins merged 1 commit intomainfrom
20260317-allow-editing-of-first_notification_milestone-for-current-release
Mar 18, 2026
Merged

Allow editing of first_notification_milestone for current release.#6127
jrobbins merged 1 commit intomainfrom
20260317-allow-editing-of-first_notification_milestone-for-current-release

Conversation

@jrobbins
Copy link
Collaborator

@jrobbins jrobbins commented Mar 17, 2026

The Enterprise team requested the ability to edit the first_notification_milestone even if that affects the release notes for the current milestone. Previously, the server-side implemented a rule that prevented using any first_notification_milestone that used the milestone that was currently on the stable channel.

In this PR:

  • Change is_update_first_notification_milestone() to allow entering milestone M or editing an existing value M, unless M+1 has a stable_date in the past. This means that M's stable date can be current or future.

Note that the client-side warnings are unchanged. They never prevented users from entering any value, and it is probably still a good idea to keep the warning to discourage adding and removing items from the currently-live release notes.

@jrobbins jrobbins added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit cc7e530 Mar 18, 2026
8 checks passed
@jrobbins jrobbins deleted the 20260317-allow-editing-of-first_notification_milestone-for-current-release branch March 18, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants