Skip to content

tests: lantern trace data must now be downloaded manually #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulirish wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests: lantern trace data must now be downloaded manually #16789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aee71d
test: pull lantern traces manually
paulirish Nov 20, 2025
e19506a
Merge branch 'main' into lanterntracemannual
paulirish Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- run: yarn diff:sample-json
- run: yarn diff:flow-sample-json
- run: yarn lint
- run: yarn test-lantern

- run: yarn test-legacy-javascript
env:
# https://github.com/nodejs/node/issues/51555#issuecomment-1974877052
Expand Down
2 changes: 1 addition & 1 deletion core/scripts/lantern/collect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ DEBUG=1 WPT_KEY=... node --max-old-space-size=4096 collect.js

Output will be in `dist/collect-lantern-traces`, and zipped at `dist/collect-lantern-traces.zip`.

Update the zip on Google Drive and `download-traces.sh`.
Update the zip on at http://go/lhsth and any references in `download-traces.sh`.


## Run in GCP
Expand Down
14 changes: 10 additions & 4 deletions core/scripts/lantern/download-traces.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ if [[ -f lantern-data/site-index-plus-golden-expectations.json ]] && ! [[ "$FORC
exit 0
fi


rm -rf lantern-data/
mkdir -p lantern-data/ && cd lantern-data

curl -o golden-lantern-traces.zip -L https://storage.googleapis.com/lh-lantern-data/golden-lantern-traces-$VERSION.zip

unzip -q golden-lantern-traces.zip
rm golden-lantern-traces.zip
echo $VERSION > version

echo "Manual steps due to data download restrictions:"
echo "open http://go/lhsth "
echo "cd $LH_ROOT_PATH"
echo "download golden-lantern-traces-$VERSION.zip to $LH_ROOT_PATH"
echo "rename to golden-lantern-traces.zip"
echo "unzip it."
echo "then delete the zip".

Loading