-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Protonull #16810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ricardosteffen545-commits
wants to merge
675
commits into
GoogleChrome:psithing
from
ricardosteffen545-commits:protonull
Closed
Protonull #16810
ricardosteffen545-commits
wants to merge
675
commits into
GoogleChrome:psithing
from
ricardosteffen545-commits:protonull
+104,142
−32,633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* i18n runtime settings & dropdown. Modify ui-feat for i18n. * Wrongly added this localeString mod * Messed up some HTML while editing the strings. * Ignore report-ui-feat from collect-strings. Update proto, update samples. * stringback * this -> Util * Add proto comments. * convert \t to _ because regex is hard * collected en-XL * let -> const * updated id's * Added caching/hydration to Util * hm, not sure how that worked, but okay * net -> network * data-i18n attr * update sample json * keyof! * forEach -> for of * add test * Connor's nits Co-Authored-By: Connor Clark <cjamcl@google.com> * Remove backup English from html, remove useless ignorePaths * fix tests * Revert "fix tests" This reverts commit 4c89c0f. * ignore axe link-name Co-authored-by: Connor Clark <cjamcl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues/PRs