Protonull #16810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

ricardosteffen545-commits wants to merge 675 commits into GoogleChrome:psithing from ricardosteffen545-commits:protonull

.appveyor.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,7 @@ install: @@
     before_test:
       - set "PATH=C:\MinGW\msys\1.0\bin;%PATH%"
-      - set "LIGHTHOUSE_CHROMIUM_PATH=%CD%\chrome-win32\chrome.exe"
+      - set "CHROME_PATH=%CD%\chrome-win32\chrome.exe"
       - bash ./lighthouse-core/scripts/download-chrome.sh
       - yarn build-all
@@ Expand All / @@ -32,13 +32,20 @@ test_script: @@
       - which yarn
       - yarn lint
       - yarn unit-core --runInBand
-      - yarn unit-cli
+      # Appveyor protocol timeouts are unusually common.
+      # We retry our smoketests 3 times for this reason, so do the same for CLI tests that launch Chrome.
+      - yarn unit-cli || yarn unit-cli || yarn unit-cli
       - yarn unit-viewer
       - yarn type-check
-      # FIXME: Exclude Appveyor from running `perf` smoketest until we fix the flake.
-      #     https://github.com/GoogleChrome/lighthouse/issues/5053
-      # - yarn smoke
-      - yarn smoke a11y pwa pwa2 pwa3 dbw redirects seo offline byte metrics
+      # run smoke tests serially, trying up to three times to prevent flakes.
+      # FIXME: Exclude Appveyor from running `lantern` smoketest until we fix the flake.
+      - yarn smoke -j=1 --retries=2 a11y errors oopif pwa pwa2 pwa3 dbw redirects seo offline byte perf metrics
+    on_success:
+      # Remove module resolution symlinks; this avoids 'Unable to save cache'
+      # errors when appveyor runs 7z.exe to save the build cache
+      - yarn unlink lighthouse
+      - yarn unlink
     cache:
       #- chrome-win32 -> appveyor.yml,package.json
@@ Expand Down @@

.build-for-now.sh

This file was deleted.

.cz-config.js

-Original file line number
+Diff line change
@@ -1,5 +1,5 @@
     /**
-     * @license Copyright 2017 Google Inc. All Rights Reserved.
+     * @license Copyright 2017 The Lighthouse Authors. All Rights Reserved.
      * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
      * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
      */
@@ Expand Down @@

.eslintignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -4,9 +4,15 @@ @@
     **/node_modules/**
     **/third_party/**
+    **/generated/**
+    **/source-maps/**
+    lighthouse-cli/test/fixtures/byte-efficiency/bundle.js
     /dist/**
     coverage/**
     !.eslintrc.js
+    lighthouse-core/scripts/legacy-javascript/variants

.eslintrc.js

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,5 +1,5 @@
  
    /**

     * @license Copyright 2017 Google Inc. All Rights Reserved.

     * @license Copyright 2017 The Lighthouse Authors. All Rights Reserved.

     * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0

     * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

     */

    @@ -9,6 +9,7 @@ module.exports = {
  
      // start with google standard style

      //     https://github.com/google/eslint-config-google/blob/master/index.js

      extends: ['eslint:recommended', 'google'],

      plugins: ['eslint-plugin-local-rules'], // include custom rules

      env: {

        node: true,

        es6: true,

    @@ -49,7 +50,7 @@ module.exports = {
  
        'no-unused-vars': [2, {

          vars: 'all',

          args: 'after-used',

          argsIgnorePattern: '(^reject$|^_$)',

          argsIgnorePattern: '(^reject$|^_+$)',

          varsIgnorePattern: '(^_$)',

        }],

        'space-infix-ops': 2,

    @@ -64,11 +65,22 @@ module.exports = {
  
          functions: 'never',

        }],

        // Custom lighthouse rules

        'local-rules/require-file-extension': 2,

        // Disabled rules

        'require-jsdoc': 0,

        'valid-jsdoc': 0,

        'arrow-parens': 0,

      },

      overrides: [

        {

          files: ['lighthouse-cli/test/smokehouse/**/*expectations.js'],

          rules: {

            'max-len': 0,

          },

        },

      ],

      parserOptions: {

        ecmaVersion: 2018,

        ecmaFeatures: {

.github/CODEOWNERS

-Original file line number
+Diff line change
@@ -1,21 +1,9 @@
-    # Each line is a file pattern followed by one or more owners.
-    # Order is important. The last matching pattern has the most precedence.
-    # https://help.github.com/articles/about-codeowners/
-    lighthouse-cli/                     @patrickhulce       @paulirish
-    lighthouse-cli/test/fixtures/       @patrickhulce       @brendankenny
-    lighthouse-cli/test/smokehouse/     @patrickhulce       @brendankenny
+    # This file pairs with the automated code review assignment setting to make that system work
+    #   https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/managing-code-review-assignment-for-your-team
-    lighthouse-core/gather/             @patrickhulce       @paulirish
-    lighthouse-core/audits/             @patrickhulce       @brendankenny   @paulirish
-    lighthouse-core/report/             @paulirish
+    # Docs: https://help.github.com/articles/about-codeowners/
-    lighthouse-core/config/             @patrickhulce       @brendankenny
-    lighthouse-core/lib/                @brendankenny       @paulirish
-    clients/                            @paulirish          @patrickhulce
-    lighthouse-viewer/                  @ebidel             @brendankenny
-    docs/                               @paulirish
-    proto/                              @brendankenny       @exterkamp
-    # no explicit owner for travis, etc
+    # default owners for the entire repo
+    *      @GoogleChrome/lighthouse-hackers

.github/ISSUE_TEMPLATE/Bug_report.md

-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,8 @@ about: Report something working incorrectly @@
     #### Provide the steps to reproduce
 . Run LH on <affected url>
+    <!-- If your page is only local, or is liable to change, consider uploading a repro so that we can more easily debug the problem. Some services that will help are: https://jsbin.com/, https://surge.sh/ -->
     #### What is the current behavior?
@@ Expand All / @@ -19,6 +21,7 @@ about: Report something working incorrectly @@
     #### Environment Information
     * Affected Channels: <!-- CLI, Node, Extension, DevTools -->
     * Lighthouse version:
+    * Chrome version: <!-- chrome://version/ -->
     * Node.js version:
     * Operating System:
@@ Expand Down @@

.github/PULL_REQUEST_TEMPLATE.md

-Original file line number
+Diff line change
@@ -1,4 +1,8 @@
-    <!-- Thank you for submitting a pull request! -->
+    <!--
+    Thank you for submitting a pull request!
+    See CONTRIBUTING.MD for help in getting a change landed.
+      https://github.com/GoogleChrome/lighthouse/blob/master/CONTRIBUTING.md
+    -->
     **Summary**
     <!-- What kind of change does this PR introduce? -->
@@ Expand Down @@

.github/workflows/ci.yml

-Original file line number
+Diff line change
@@ -0,0 +1,85 @@
+    # The Travis CI is our full-fledged CI, but this Github workflow
+    # runs the same tests. The GH workflow UI makes it simpler to hone
+    # in on the step that failed.
+    name: 💡🏠
+    on: [push]
+    jobs:
+      ci:
+        runs-on: ubuntu-latest
+        strategy:
+          # e.g. if lint fails, continue to the unit tests anyway
+          fail-fast: false
+        steps:
+        - name: git clone
+          uses: actions/checkout@v2
+        - name: Use Node.js 10.x
+          uses: actions/setup-node@v1
+          with:
+            node-version: 10.x
+        - name: Setup protoc
+          uses: arduino/setup-protoc@7ad700d
+          with:
+            version: '3.7.1'
+            repo-token: ${{ secrets.GITHUB_TOKEN }}
+        - name: Set up Python
+          uses: actions/setup-python@v1
+          with:
+            python-version: 2.7
+        - name: Install Python dependencies
+          run: |
+            python -m pip install --upgrade pip
+            pip install protobuf==3.7.1
+        # Cache yarn deps. thx https://github.com/actions/cache/blob/master/examples.md#node---yarn
+        - name: Get yarn cache directory path
+          id: yarn-cache-dir-path
+          run: echo "::set-output name=dir::$(yarn cache dir)"
+        - name: Set up node_modules cache
+          uses: actions/cache@v1
+          id: yarn-cache
+          with:
+            path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+            key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+            restore-keys: |
+              ${{ runner.os }}-yarn-
+        - run: yarn --frozen-lockfile
+        - run: yarn build-all
+        - run: yarn diff:sample-json
+        # - run: yarn type-check
+        # - run: yarn lint
+        - run: yarn test-proto # Run before unit-core because the roundtrip json is needed for proto tests.
+        # Run tests that require headfull Chrome.
+        - run: sudo apt-get install xvfb
+        - run: xvfb-run --auto-servernum yarn jest report/proto-test.js
+        # - run: xvfb-run --auto-servernum yarn test-clients
+        # - run: xvfb-run --auto-servernum yarn smoke -j=1 --retries=2
+        # - run: xvfb-run --auto-servernum yarn test-bundle
+        # - run: xvfb-run --auto-servernum yarn test-docs
+        # - run: yarn test-lantern
+        # - run: yarn test-legacy-javascript
+        # - run: yarn i18n:checks
+        # - run: yarn dogfood-lhci
+        # buildtracker runs `git merge-base HEAD origin/master` which needs more history than depth=1. https://github.com/paularmstrong/build-tracker/issues/106
+        # - name: Deepen git fetch (for buildtracker)
+          # run: git fetch --deepen=100
+        # - name: Store in buildtracker
+          # TODO(paulirish): Don't allow this to fail the build. https://github.com/paularmstrong/build-tracker/issues/200
+          # run: yarn bt-cli upload-build || true
+          # env:
+            # https://buildtracker.dev/docs/guides/github-actions#configuration
+            # BT_API_AUTH_TOKEN: ${{ secrets.BT_API_AUTH_TOKEN }}
+        # Fail if any changes were written to source files (ex, from: build/build-cdt-lib.js).
+        # - run: git diff --exit-code

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -3,6 +3,7 @@ node_modules @@
     npm-debug.log
     .vscode
     .tmp
+    .idea
     /dist
     coverage
@@ Expand All / @@ -22,14 +23,20 @@ last-run-results.html @@
     *.report.csv
     *.report.pretty
     *.artifacts.log
+    *.ctc.json
     !lighthouse-core/test/results/artifacts/*.trace.json
     !lighthouse-core/test/results/artifacts/*.devtoolslog.json
     !lighthouse-core/test/fixtures/artifacts/**/*.trace.json
     !lighthouse-core/test/fixtures/artifacts/**/*.devtoolslog.json
+    !lighthouse-core/test/fixtures/traces/**/*.trace.json
+    !lighthouse-core/test/fixtures/traces/**/*.devtoolslog.json
+    lighthouse-core/scripts/legacy-javascript/variants
     latest-run
     lantern-data
+    timings-data
     closure-error.log
     yarn-error.log
@@ Expand All / @@ -43,3 +50,8 @@ yarn-error.log @@
     proto/scripts/*_pb2.*
     proto/scripts/*_pb.*
     proto/scripts/*_processed.json
+    # require any lock file to be checked in explicitly
+    yarn.lock
+    proto/sample_v2_round_trip.json

.mailmap

-Original file line number
+Diff line change
@@ -0,0 +1,6 @@
+    Brendan Kenny <bckenny@gmail.com> Brendan Kenny <bckenny@google.com>
+    Connor Clark <cjamcl@gmail.com> cjamcl <cjamcl@google.com>
+    Connor Clark <cjamcl@gmail.com> Connor Clark <cjamcl@google.com>
+    Patrick Hulce <patrick.hulce@gmail.com> Patrick Hulce <phulce@google.com>
+    Paul Irish <paul.irish@gmail.com> Paul Irish <paulirish@google.com>
+    Paul Lewis <github@aerotwist.com> Paul Lewis <gravatar@aerotwist.com>

.npmignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,7 @@ assets/ @@
     build/
     coverage/
     dist/
+    proto/
     lighthouse-core/scripts/*
     lighthouse-core/test/
@@ Expand All / @@ -23,10 +24,13 @@ lighthouse-logger/ @@
     # keep smokehouse tests, etc
     !lighthouse-cli/test
-    node_modules/
     results/
     lantern-data/
-    latest-run/
+    timings-data/
+    # ignore all folders named as such
+    node_modules
+    latest-run
     # generated files
     **/pages/scripts/lighthouse-report.js
@@ Expand All / @@ -49,3 +53,4 @@ results.html @@
     .eslintignore
     .eslintrc.js
     .travis.yml
+    *.tgz

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Protonull #16810

Uh oh!

Diff view

Diff view

Uh oh!

There are no files selected for viewing

Uh oh!

Uh oh!