core: set NetworkRequest.renderBlocking from CDP data#16869
Open
iamakulov wants to merge 3 commits intoGoogleChrome:mainfrom
Open
core: set NetworkRequest.renderBlocking from CDP data#16869iamakulov wants to merge 3 commits intoGoogleChrome:mainfrom
iamakulov wants to merge 3 commits intoGoogleChrome:mainfrom
Conversation
iamakulov
force-pushed
the
core/cdp-render-blocking
branch
from
42e1d82 to
3101992
Compare
This was referenced Jan 29, 2026
paulirish
approved these changes
Feb 2, 2026
| const HEADER_PROTOCOL_IS_H2 = 'X-ProtocolIsH2'; | ||
|
|
||
| // CDP uses PascalCase (M145+), Lantern uses snake_case. | ||
| /** @type {Record<LH.Crdp.Network.RenderBlockingBehavior, Lantern.Types.RenderBlocking>} */ |
Member
There was a problem hiding this comment.
Author
|
(Heads-up that I don't have collaborator permissions so you folks need to merge this one yourself :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a sibling PR to https://chromium-review.googlesource.com/c/chromium/src/+/7269488 and https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7262577. It drills the
renderBlockingBehaviorflag introduced in the former, and makes it available to core Lantern login in the latter.The practical impact of this is that FCP and LCP start using more accurate render-blocking data (starting with M145).
Related Issues/PRs
#16539