Simplify the event and LoAF entry clean up logic #662
Merged
+34
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
commented
Dec 19, 2025
tunetheweb
requested changes
Dec 29, 2025
Member
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
I'm not 100% convinced this PR is actually that much of an improvement. See comments above, but especially for these next two comments:
Co-authored-by: Barry Pollard <[email protected]>
tunetheweb
reviewed
Jan 7, 2026
tunetheweb
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates logic and comments in the
queueCleanup()function forattribution/onINP.tsto make it easier to follow what's happening.