Add spanner adapter layer for ListBaselineStatusCounts#1142
Merged
jcscottiii merged 1 commit intomainfrom Feb 10, 2025
Merged
Conversation
DanielRyanSmith
approved these changes
Feb 7, 2025
Collaborator
DanielRyanSmith
left a comment
DanielRyanSmith
left a comment
There was a problem hiding this comment.
I just noticed that GitHub displays these PRs with 8-space block indentation. I see 4-space blocks locally. I'm not sure why this is 🤔 maybe specific to Go?
This is the adapter layer for ListBaselineStatusCounts between the http and spanner layers. This is similar to TestListMissingOneImplCounts
jcscottiii
force-pushed
the
jcscottiii/glue-layer-baseline-counts
branch
from
397ba9c to
cda7cd0
Compare
Collaborator
Author
Never noticed it before. I wonder if it is specific to GitHub's rendering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1132
This is the adapter layer for ListBaselineStatusCounts between the http and spanner layers.
This is similar to ListMissingOneImplCounts (also used on the stats page)