Change the start date to 2020-01-01 for stats page#1162
Merged
jcscottiii merged 1 commit intomainfrom Feb 12, 2025
Merged
Conversation
Previously, the stats page showed only a year's worth of data. This change overrides the start date to explicitly be 2020-01-01.
Collaborator
|
It seems like we also have to set a duration or end date? It should show 2020-today by default. |
Collaborator
Author
|
Good question! I should have noted that the tests use a fake Date.now() (see link) for the end date to ensure consistent screenshots. This prevents the times from changing, which would cause the tests to fail across different days. However, when deployed, the actual date will be from 2020 to the present. Here's how it will appear in the live version.
|
Collaborator
|
Ah, perfect! Thank you! This looks great! Also, unrelated, but could capitalize the names of the browsers? |
atopal
approved these changes
Feb 12, 2025
Collaborator
Author
We can definitely do that. I'll do that shortly |
jcscottiii
added this to the
Q1 '25 - #6: Make the stats page discoverable by default milestone
jcscottiii
added a commit
that referenced
this pull request
Feb 12, 2025
This addresses this feedback #1162 (comment) It uses the existing BROWSER_ID_TO_LABEL variable that we use on the feature detail page.
jcscottiii
added a commit
that referenced
this pull request
Feb 13, 2025
This addresses this feedback #1162 (comment) It uses the existing BROWSER_ID_TO_LABEL variable that we use on the feature detail page.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
This addresses this feedback #1162 (comment) It uses the existing BROWSER_ID_TO_LABEL variable that we use on the feature detail page.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
This addresses this feedback #1162 (comment) It uses the existing BROWSER_ID_TO_LABEL variable that we use on the feature detail page.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the stats page showed only a year's worth of data (by setting the start date 1 year in the past from the current date).
This change overrides the start date to explicitly be 2020-01-01.