Skip to content

Prevent page refresh if present result is same as result to be searched #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcscottiii merged 3 commits into from
Mar 16, 2025
Merged

Prevent page refresh if present result is same as result to be searched #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cfe1ca
Prevent page refresh if present result is same as result to be searched
suprith-hub Mar 11, 2025
1dc9b69
Use complete url instead of path
suprith-hub Mar 12, 2025
efd3532
Logic should be in utils, use new URL
suprith-hub Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/static/js/components/webstatus-overview-filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ import {

import {CSVUtils} from '../utils/csv.js';
import {Toast} from '../utils/toast.js';
import {navigateToUrl} from '../utils/app-router.js';

const WEBSTATUS_FEATURE_OVERVIEW_CSV_FILENAME =
'webstatus-feature-overview.csv';
Expand Down Expand Up @@ -233,7 +234,7 @@ export class WebstatusOverviewFilters extends LitElement {
q: (this.typeaheadRef.value as WebstatusTypeahead).value,
start: 0,
});
window.location.href = newUrl;
navigateToUrl(newUrl);
}

protected firstUpdated(): void {
Expand Down
8 changes: 8 additions & 0 deletions frontend/src/static/js/utils/app-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ export const navigateToUrl = (url: string, event?: MouseEvent) => {
return;
}

// Construct a full URL to handle relative paths correctly
const fullNewUrl = new URL(url, window.location.origin).href; // TODO for future - handle try/catch case until we use AppLocation

const currentUrl = window.location.href;
if (currentUrl === fullNewUrl) {
return;
}

// TODO. We should use the vaadin router and use the navigate method there.
window.location.href = url;
};
Expand Down
Loading