Improved Parenthesis Handling and Spanner Limit Mitigation#1272
Merged
jcscottiii merged 2 commits intomainfrom Mar 17, 2025
Merged
Improved Parenthesis Handling and Spanner Limit Mitigation#1272jcscottiii merged 2 commits intomainfrom
jcscottiii merged 2 commits intomainfrom
Conversation
This PR improves search query generation by: - Grammar: Adding parenthesizedCriteria to explicitly capture parenthesized expressions. - Visitor: Updating the visitor to create SearchNode objects with parenthesis information. - Filter Generation: Refactoring traverseAndGenerateFilters to correctly handle parentheses and minimize unnecessary nesting in Spanner queries, mitigating Spanner's complexity limits. Without this change, a user cannot query more than 50 ids at a given time.
KyleJu
reviewed
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves search query generation by:
traverseAndGenerateFiltersto correctly handle parentheses and minimize unnecessary nesting in Spanner queries, mitigating Spanner's complexity limits.Without this change, a user cannot query more than 50 ids at a given time.