Allow overview-page components to use appBookmarkInfoContext to automatically load public user saved searches#1329
Merged
jcscottiii merged 1 commit intomainfrom Mar 27, 2025
Conversation
jcscottiii
changed the title
jrobbins
approved these changes
Mar 26, 2025
jcscottiii
force-pushed
the
jcscottiii/ui-searches-v4.8.2
branch
from
b0bd7df to
43cdf54
Compare
jcscottiii
force-pushed
the
jcscottiii/ui-searches-v4.8.3
branch
from
ca15e14 to
45db461
Compare
This change subscribes various overview page components to appBookmarkInfoContext so that it can get bookmark info. I also introduced a new Error for TaskTracker: TaskNotReadyError We need this error so that the call to getFeatures waits until we have gotten the information from user saved searches API. You will see the changes in webstatus-overview-page.ts that use that new error. TODO: - When it comes to editing and creating these bookmarks, we will probably move around some of these components (Which might simplify the number of components subscribed to appBookmarkInfoContext). In the meantime, I did not add too many unit tests but instead added some e2e tests in playwright to help give some coverage.
jcscottiii
force-pushed
the
jcscottiii/ui-searches-v4.8.3
branch
from
45db461 to
6353021
Compare
Closed
3 tasks
Closed
3 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1328
This change subscribes various overview page components to appBookmarkInfoContext so that it can get bookmark info.
I also introduced a new Error for TaskTracker: TaskNotReadyError We need this error so that the call to getFeatures waits until we have gotten the information from user saved searches API.
You will see the changes in webstatus-overview-page.ts that use that new error.
Future PR TODO: