Merged
Conversation
jcscottiii
force-pushed
the
jcscottiii/add-editor
branch
5 times, most recently
from
83882a5 to
246f0a1
Compare
This introduces a new form for the saved search component. We currently are not rendering this shoelace dialog. That will happen in a future PR along with some playwright tests. This dialog handles the creation, updating and deletion of the saved search.
jcscottiii
force-pushed
the
jcscottiii/add-editor
branch
from
246f0a1 to
b11c799
Compare
jcscottiii
added a commit
that referenced
this pull request
Apr 21, 2025
This component will be entrypoint to controlling saved searches and bookmark status on the overview page. For creating/updating/deleting saved searches, this component will open the saved search editor component created in #1411 For bookmarking/unbookmarking, the controls component itself will handle the HTTP tasks to toggle the status. This component will dispatch either `saved-search-bookmarked` or `saved-search-unbookmarked` which will be handled by webstatus-bookmarks-service
jcscottiii
added a commit
that referenced
this pull request
Apr 21, 2025
This component will be entrypoint to controlling saved searches and bookmark status on the overview page. For creating/updating/deleting saved searches, this component will open the saved search editor component created in #1411 For bookmarking/unbookmarking, the controls component itself will handle the HTTP tasks to toggle the status. This component will dispatch either `saved-search-bookmarked` or `saved-search-unbookmarked` which will be handled by webstatus-bookmarks-service
jcscottiii
added a commit
that referenced
this pull request
Apr 21, 2025
This component will be entrypoint to controlling saved searches and bookmark status on the overview page. For creating/updating/deleting saved searches, this component will open the saved search editor component created in #1411 For bookmarking/unbookmarking, the controls component itself will handle the HTTP tasks to toggle the status. This component will dispatch either `saved-search-bookmarked` or `saved-search-unbookmarked` which will be handled by webstatus-bookmarks-service
jrobbins
approved these changes
Apr 22, 2025
Collaborator
jrobbins
left a comment
jrobbins
left a comment
There was a problem hiding this comment.
LGTM after some questions.
frontend/src/static/js/components/webstatus-saved-search-editor.ts
Outdated
Show resolved
Hide resolved
jcscottiii
added a commit
that referenced
this pull request
Apr 22, 2025
This component will be entrypoint to controlling saved searches and bookmark status on the overview page. For creating/updating/deleting saved searches, this component will open the saved search editor component created in #1411 For bookmarking/unbookmarking, the controls component itself will handle the HTTP tasks to toggle the status. This component will dispatch either `saved-search-bookmarked` or `saved-search-unbookmarked` which will be handled by webstatus-bookmarks-service
jcscottiii
added a commit
that referenced
this pull request
Apr 22, 2025
This component will be entrypoint to controlling saved searches and bookmark status on the overview page. For creating/updating/deleting saved searches, this component will open the saved search editor component created in #1411 For bookmarking/unbookmarking, the controls component itself will handle the HTTP tasks to toggle the status. This component will dispatch either `saved-search-bookmarked` or `saved-search-unbookmarked` which will be handled by webstatus-bookmarks-service
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
This component will be entrypoint to controlling saved searches and bookmark status on the overview page. For creating/updating/deleting saved searches, this component will open the saved search editor component created in #1411 For bookmarking/unbookmarking, the controls component itself will handle the HTTP tasks to toggle the status. This component will dispatch either `saved-search-bookmarked` or `saved-search-unbookmarked` which will be handled by webstatus-bookmarks-service
Closed
This was
linked to
issues
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new form for the saved search component.
We currently are not rendering this shoelace dialog. That will happen in a future PR along with some playwright tests.
This dialog handles the creation, updating and deletion of the saved search.
This dialog re-uses the typeahead component with the vocabulary.
If a user is currently editing a query, it will be passed into the dialog so that they will not need to copy the query from the overview page typeahead to the dialog typeahead.
Other changes:
This is a split up of #1364 but with tests added