Skip to content

Render saved search editor dialog and bookmark controls#1423

Merged
jcscottiii merged 2 commits intomainfrom
jcscottiii/render-saved-search-controls-and-editor
Apr 24, 2025
Merged

Render saved search editor dialog and bookmark controls#1423
jcscottiii merged 2 commits intomainfrom
jcscottiii/render-saved-search-controls-and-editor

Conversation

@jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented Apr 22, 2025

This is the final split up of #1364

Previous commits added the components for the saved search editor dialog
and bookmark controls. This commit renders those controls component (which then renders the dialog component)

The controls only appear for authenticated users.

image

image

image

Other changes:

  • Add a data reset mode to the fake data script. Use this as part of the hooks for the saved search playwright tests.

@jcscottiii jcscottiii force-pushed the jcscottiii/add-controls branch from dd1ec0b to 0db6eeb Compare April 22, 2025 20:56
@jcscottiii jcscottiii changed the title Jcscottiii/render saved search controls and editor Render saved search editor dialog and bookmark controls Apr 22, 2025
Base automatically changed from jcscottiii/add-controls to main April 23, 2025 00:20
@jcscottiii jcscottiii force-pushed the jcscottiii/render-saved-search-controls-and-editor branch 5 times, most recently from 922e33e to 5460a4c Compare April 23, 2025 14:30
Previous commits added the components for the saved search editor dialog
and bookmark controls. This commit renders those controls component (which then renders the dialog component)

The controls only appear for authenticated users.
@jcscottiii jcscottiii force-pushed the jcscottiii/render-saved-search-controls-and-editor branch from 5460a4c to 5937286 Compare April 23, 2025 22:04
@jcscottiii jcscottiii added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit bcc9a08 Apr 24, 2025
7 checks passed
@jcscottiii jcscottiii deleted the jcscottiii/render-saved-search-controls-and-editor branch April 24, 2025 00:19
@jcscottiii jcscottiii mentioned this pull request Apr 24, 2025
@jcscottiii jcscottiii added this to the Q1 '25 - #1 Saved Searches milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants