Refactor(web_feature_consumer): Use ProcessedWebFeaturesData for insertion#1750
Merged
jcscottiii merged 1 commit intomainfrom Aug 22, 2025
Merged
Conversation
jcscottiii
force-pushed
the
jcscottiii/refactor-insert-web-features
branch
from
f41c61f to
f9fbff3
Compare
…rtion This commit refactors the InsertWebFeatures function and its call sites to use the ProcessedWebFeaturesData struct instead of a raw map of features. In the future, we will need this information to know which features were moved.
jcscottiii
force-pushed
the
jcscottiii/refactor-insert-web-features
branch
from
f9fbff3 to
48d57c7
Compare
jrobbins
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the InsertWebFeatures function and its call sites to use the ProcessedWebFeaturesData struct instead of a raw map of features.
In the future, we will need this information to know which features were moved so we know how to moved data around.