Skip to content

Don't automatically select 0th autocomplete candidate #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcscottiii merged 2 commits into from
Aug 22, 2025
Merged

Don't automatically select 0th autocomplete candidate #1753

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76ad72
Don't automatically select 0th autocomplete candidate
jcscottiii Aug 22, 2025
bcfcc0e
Update frontend/src/static/js/components/webstatus-typeahead.ts
jcscottiii Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions frontend/src/static/js/components/webstatus-typeahead.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
type TemplateResult,
css,
html,
nothing,
} from 'lit';
import {customElement, property, state} from 'lit/decorators.js';
import {SHARED_STYLES} from '../css/shared-css.js';
Expand Down Expand Up @@ -289,6 +290,7 @@ export class WebstatusTypeahead extends LitElement {
@click=${(e: Event) => e.preventDefault()}
@sl-select=${this.handleCandidateSelected}
>
<webstatus-typeahead-invisible-item></webstatus-typeahead-invisible-item>
${this.candidates.map(
c => html`
<webstatus-typeahead-item
Expand Down Expand Up @@ -318,7 +320,11 @@ export class WebstatusTypeahead extends LitElement {
@customElement('webstatus-typeahead-dropdown')
export class WebstatusTypeaheadDropdown extends SlDropdown {
getCurrentItem(): SlMenuItem | undefined {
return this.getMenu()!.getCurrentItem();
const item = this.getMenu()!.getCurrentItem();
if (!item || item instanceof WebstatusTypeaheadInvisibleItem) {
return undefined;
}
return item;
}

setCurrentItem(newCurrentItem: SlMenuItem) {
Expand All @@ -327,6 +333,13 @@ export class WebstatusTypeaheadDropdown extends SlDropdown {
newCurrentItem.scrollIntoView({block: 'nearest', behavior: 'smooth'});
}

getAllVisibleItems(menu: SlMenu): SlMenuItem[] {
const items = menu.getAllItems();
return items.filter(
item => !(item instanceof WebstatusTypeaheadInvisibleItem),
);
}

resetSelection() {
const currentItem = this.getCurrentItem();
currentItem?.setAttribute('tabindex', '-1');
Expand All @@ -337,10 +350,7 @@ export class WebstatusTypeaheadDropdown extends SlDropdown {
if (!menu) {
return;
}
const menuItems = menu.getAllItems();
if (menuItems.length === 0) {
return;
}
const menuItems = this.getAllVisibleItems(menu);
const currentItem = menu.getCurrentItem();

// Handle menu selection keys.
Expand Down Expand Up @@ -480,3 +490,10 @@ export class WebstatusTypeaheadItem extends LitElement {
`;
}
}

@customElement('webstatus-typeahead-invisible-item')
export class WebstatusTypeaheadInvisibleItem extends WebstatusTypeaheadItem {
override render(): TemplateResult {
return html`${nothing}`;
}
}