feat: Enhance developer signals with upvotes and link#1788
Merged
jcscottiii merged 1 commit intomainfrom Sep 9, 2025
Merged
Conversation
jcscottiii
force-pushed
the
jcscottiii/get-feature-signals-glue
branch
from
7f177db to
a1c5aef
Compare
This commit refactors the developer signals feature to provide more detailed information. The previous `positive_count` is replaced with `upvotes` and a `link` to the source of the signal (e.g., a GitHub issue). Key changes include: - Updated the OpenAPI spec to reflect the new `DeveloperSignal` structure and added sorting by upvotes. - Modified database queries and models to join and retrieve the new `upvotes` and `link` fields from the `LatestFeatureDeveloperSignals` table. - Implemented sorting logic for `developer_signal_upvotes`. - Added a pre-delete hook to migrate developer signals when a web feature's key changes, ensuring data integrity. Fixes #1675
jcscottiii
force-pushed
the
jcscottiii/get-feature-signals-glue
branch
from
a1c5aef to
a44dfc5
Compare
jrobbins
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the developer signals feature to provide more detailed information. The previous
positive_countis replaced withupvotesand alinkto the source of the signal (e.g., a GitHub issue).Key changes include:
DeveloperSignalstructure and added sorting by upvotes.upvotesandlinkfields from theLatestFeatureDeveloperSignalstable.developer_signal_upvotes.Fixes #1675