Add missing deletion_protection variable for terraform resource#1909
Merged
jcscottiii merged 1 commit intomainfrom Oct 8, 2025
Merged
Add missing deletion_protection variable for terraform resource#1909jcscottiii merged 1 commit intomainfrom
jcscottiii merged 1 commit intomainfrom
Conversation
Some GCP terraform resources have an optional property named deletion_protection. With it, terraform will not delete it. It defaults to true for staging and prod.\ But false when deploying your own [copy](https://github.com/GoogleChrome/webstatus.dev/blob/main/DEPLOYMENT.md#deploying-your-own-copy). When I was cleaning up old dev environments, I could not cleanly delete them because this particular resource had deletion_protection set to true by default. This change uses the global variable which allows us to explicitly tell if we want that given resource to have deletion_protection.
DanielRyanSmith
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some GCP terraform resources have an optional property named deletion_protection.
With it, terraform will not delete it. It defaults to true for staging and prod. But false when deploying your own copy.
When I was cleaning up old dev environments, I could not cleanly delete them because this particular resource had deletion_protection set to true by default. This change uses the global variable which allows us to explicitly tell if we want that given resource to have deletion_protection.