Ensure that URL constructor is globally available#18
Ensure that URL constructor is globally available#18vladimyr wants to merge 2 commits intoGoogleChromeLabs:masterfrom
Conversation
WHATWG URL API has been implemented since v7 but global URL constructor was added later as part of v10 release.
|
Hi @vladimyr . Thanks for the PR! Just wondering if there is a need to export URL and URLSearchParams, since we are proving methods around it? Also URL and URLSearchParams will be available globally in all cases (with the new changes). |
|
Strictly speaking, there is no need to export it but it is neat in case you have existing node codebase and you are trying to update it by swapping usages of node's builtin const { URL } = require('url');I understand that the primary intention of this package is to implement legacy URL API on top of WHATWG's work and not producing a replacement for the node's builtin url module. That being said node's |
|
@janicklas-ralph What do you think? |
|
Sorry about the late response! Thats a very valid point. Let me check out and test the changes before merging this |
|
Hi, want to check if there is some update for the changes :) We tried to globally replace node |
WHATWG URL API has been implemented since v7 but global
URLconstructor was added later as part of v10 release.