Skip to content

Conversation

@XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Mar 24, 2025

@addyosmani I split this from #418. Could you have a look please?

I'd also like to preconnect to https://api.github.com/ in index, but I'm not 100% sure the patch is right, maybe it needs crossorigin? See 6c34047

Preview: https://deploy-preview-441--google-chrome-labs-quicklink.netlify.app/

@XhmikosR XhmikosR marked this pull request as ready for review March 24, 2025 07:38
@XhmikosR XhmikosR added the site label Mar 24, 2025
@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Apr 3, 2025

@addyosmani friendly ping so that we can move ahead to a new version. See also #421, #403 and #368.

Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through the changes and am happy with us to move forward with them. Thanks so much for all of your help here, @XhmikosR!

@addyosmani
Copy link
Collaborator

I'd also like to preconnect to https://api.github.com/ in index, but I'm not 100% sure the patch is right, maybe it needs crossorigin? See 6c34047

Commented on the commit, but we're all good without the crossorigin attribute there

@XhmikosR XhmikosR merged commit 334297b into main Apr 4, 2025
11 checks passed
@XhmikosR XhmikosR deleted the xmr/site branch April 4, 2025 04:59
@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Apr 4, 2025

With all the changes so far on main comparing the production site with the Netlify branch (which isn't 1:1 due to caching the differences in the CDN) and Regular 2G on Firefox:

  • Production:
36 requests
234.13 kB / 90.05 kB transferred
Finish: 4.45 s
DOMContentLoaded: 3.44 s
load: 3.45 s

  • main:
24 requests
152.77 kB / 80.29 kB transferred
Finish: 2.79 s
DOMContentLoaded: 758 ms
load: 763 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants