Conversation
Collaborator
Author
|
@addyosmani friendly ping so that we can move ahead to a new version. See also #421, #403 and #368. |
addyosmani
approved these changes
Apr 4, 2025
Collaborator
addyosmani
left a comment
There was a problem hiding this comment.
I've looked through the changes and am happy with us to move forward with them. Thanks so much for all of your help here, @XhmikosR!
Browser support is good enough nowadays
Collaborator
Commented on the commit, but we're all good without the |
Collaborator
Author
|
With all the changes so far on main comparing the production site with the Netlify branch (which isn't 1:1 due to caching the differences in the CDN) and Regular 2G on Firefox:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@addyosmani I split this from #418. Could you have a look please?
I'd also like to preconnect to
https://api.github.com/in index, but I'm not 100% sure the patch is right, maybe it needscrossorigin? See 6c34047Preview: https://deploy-preview-441--google-chrome-labs-quicklink.netlify.app/