Skip to content

Conversation

@srinivasan-acn
Copy link
Contributor

Runtime Template :
jupyter 3.x breaking issue - fixed
property section not updated on edit flow - fixed

google-cloud-config :
updated the version to 0.0.11

srinivasan-acn and others added 2 commits December 16, 2025 10:10
jupyter 3.x breaking issue - fixed
property section not updated on edit flow - fixed

google-cloud-config :
updated the version to 0.0.11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @srinivasan-acn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on resolving critical bugs related to the runtime template widget, ensuring its proper functionality within Jupyter 3.x environments and correcting an issue where property sections failed to update during the edit process. Additionally, it includes an update to a core dependency, contributing to overall stability and compatibility.

Highlights

  • Jupyter 3.x Compatibility: Addressed an issue where the runtime template widget would appear blank in Jupyter 3.x environments.
  • UI Property Update: Fixed a bug where the property section was not correctly updated during the edit flow.
  • Dependency Update: Updated the 'google-cloud-jupyter-config' dependency to version '0.0.11'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces bug fixes for Jupyter 3.x compatibility and an issue with property updates in the runtime template editor. It also bumps the google-cloud-jupyter-config dependency.

The changes look good overall. The optional chaining added in labelProperties.tsx is a solid fix to prevent potential crashes.

In createRunTime.tsx, the changes aim to fix a stale state issue when updating properties. While the modification to updateLightningEngineProperty is correct, I've noted a redundant call that operates on stale state. I've left a comment with a suggestion to improve the code's clarity and correctness.

@aditee-accenture aditee-accenture merged commit 1742a0f into GoogleCloudDataproc:main Jan 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants