fix: Remove redundant empty/non-actionable per-operation Spark UI link and progress bar

[virrrat]

Remove redundant empty/non-actionable per-operation Spark UI links and progress bars shown during Spark SQL query execution with SELECT clauses.

This is a follow-up to PR #118, which addressed the issue for Spark 3.5. Due to breaking changes in Spark 4’s plan proto, additional changes are needed per this PR.

Spark 3.5 plan:

plan {
  command {
    sql_command {
      sql: "SELECT 1"
    }
  }
}

Spark 4.0 plan:

plan {
  command {
    sql_command {
      input {
        common {
          plan_id: 0
        }
        sql {
          query: "SELECT 1"
        }
      }
    }
  }
}

Old Behavior (buggy):

New Behavior (fixed):

[gemini-code-assist]

Summary of Changes

Hello @virrrat, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user experience by addressing the display of redundant and non-actionable Spark UI links and progress bars during Spark SQL query execution. It specifically adapts the codebase to breaking changes in Spark 4.0's plan structure, ensuring that progress bars are only shown when actual tasks are present and that SQL commands are correctly identified for processing. This change improves clarity and reduces visual clutter in the UI.

Highlights

• Prevented Redundant Progress Bar Display: A new condition has been added to the progress bar handler to prevent it from showing when no tasks have been received, eliminating empty or non-actionable progress bars.
• Adapted to Spark 4.0 Plan Structure: The logic for identifying SQL commands has been updated to correctly parse the new plan structure introduced in Spark 4.0, where SQL queries are now nested under sql_command.input.sql.query.
• Updated Unit Tests: Corresponding unit tests were modified to reflect the Spark 4.0 plan structure, ensuring the _sql_lazy_transformation method functions as expected with the updated proto definitions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the issue of redundant UI elements for simple Spark SQL queries by adapting the logic for breaking changes in Spark 4.0. The changes correctly identify non-actionable queries by updating the plan structure traversal and prevent the progress bar from appearing when there are no tasks. The accompanying test updates are thorough and correctly reflect the new plan structure. I've added one suggestion to refactor a condition for improved readability and maintainability. Overall, this is a solid fix.