-
Notifications
You must be signed in to change notification settings - Fork 260
[Not for review- Testing pr] Merged branch #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Dhriti07
wants to merge
77
commits into
GoogleCloudDataproc:master
Choose a base branch
from
Dhriti07:merged-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
89e6e6f
Basic read funcionality using seekable byte channel
8ca23f2
Basic read funcionality
cce94fb
added unit test setup
170df0e
Added GCSBidiWriteChannelTest
aee06c7
Adding new FinalizableWritableByteChannel
73ca561
Adding GoogleCloudStorageBidiWriteChannel
a69a3c6
Moving bidi enable options to StorageOptions since it will be used ac…
39eb56b
Remove duplicate in Storage Options
1c74bdd
Adding unit tests
73e9d3e
Bug fixes
87be3e1
Removing test implementation added for finalize in outputStream
df8d7d7
Adding flag to choose between closing without finalizing and with fin…
eeb2a94
Reverting unwanted changes
d274053
Fix comment
c1a885f
Use WritableByteChannle, finalizableWritableByteChannel is no longer …
3f88103
Modify Bidi Write Channel unit tests to use single close function wit…
92691c9
Adding FinalizableWriteableByteChannel
d685432
Fixing build
462232e
Small Changes to Bidi Read Channel for setting up read flow
46e8a17
Merge conflicts
37b2f4d
Using BlobAppendableUploadConfig to handle close action
1e0d6bd
Fixing formatting
7e307b7
Test new worker pool in Cloud Build
cedec8e
Remove machine type
e88f725
Add zonal bucket creation and testing
67b4ea2
Removing zonal bucket cases
feda206
Fix dependancy on zonal bucket cretaion
c72df10
Clean code
f6ab954
Clean code
2a29ba0
Test if zonal bucket creation works
676f270
Test if zonal bucket creation works
359d5c6
Zonal bucket creation
94befe8
Bug fix
0415e48
Bug fix
27c7eb3
Bug fix
d9c83cc
Bug fix
c5b6715
Bug fix
dd3e559
Bug fix
f8fd25d
Bug fix
e59698a
Bug fix
3fd049d
Bug fix
9976c70
Bug fix
0dbf1ca
Bug fix
252cdaf
Bug fix
7c88161
Merge branch 'write-branch' into merged-branch
680be12
Merging existing changes
543279e
Merge branch 'integ-test-branch' into merged-branch
302947f
Clean code
174ca61
Fix tests
162a9a8
Clean code
a7dd355
Commenting failing UT to test integ test setup
55d28f7
Clean code
edbb7a3
Test Fix
17136ec
Fixes
a589b5b
Fixes
bb32762
Fixes
483f464
Cleanup
02200e1
Cleanup
ccbf550
Updating cloudbuild flow
f97da62
Updating create bucket function to support ZB
ac512b8
Formatting
abc5180
Removing other tests for isolated testing
fa64241
Fix
7ff10fa
Fix
d7439ed
Fixes
a10c746
Testing
7f31982
Testing
9d94007
Updates
f6b6d59
Test
552c9e4
Fix
87830bf
Fix
83a1952
Fix
5896e5e
Fix
f2bec70
Fix
2362db5
Trigger unit tests also
1be3bba
Merged code
34329a5
Adding debugging logs
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
gcs/src/main/java/com/google/cloud/hadoop/fs/gcs/CustomFileRange.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package com.google.cloud.hadoop.fs.gcs; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import org.apache.hadoop.fs.FileRange; | ||
|
|
||
| class CustomFileRange implements FileRange { | ||
| long offset; | ||
| int length; | ||
|
|
||
| CompletableFuture<ByteBuffer> data; | ||
|
|
||
| CustomFileRange(long offset, int length) { | ||
| this.offset = offset; | ||
| this.length = length; | ||
| } | ||
|
|
||
| @Override | ||
| public long getOffset() { | ||
| return offset; | ||
| } | ||
|
|
||
| @Override | ||
| public int getLength() { | ||
| return length; | ||
| } | ||
|
|
||
| @Override | ||
| public CompletableFuture<ByteBuffer> getData() { | ||
| return data; | ||
| } | ||
|
|
||
| @Override | ||
| public void setData(CompletableFuture<ByteBuffer> completableFuture) { | ||
| data = completableFuture; | ||
| } | ||
|
|
||
| @Override | ||
| public Object getReference() { | ||
| return null; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of commented-out code appears to be the old version of the script and should be removed to keep the file clean.