Adding a local version of google.p12 file

[suryasoma]

Adding a local version of google.p12 keystore file, which is extracted from google-java-api-client and added Certigna CA certificate to it.

The default GoogleUtils.getCertificateTrustStore(), does not have Certigna ca cert which is needed for TPC in it.

google-java-api-client team has said, they will no longer support this keystore, rather mentioned for us to have this local copy in the interim and then move to read from the Java Keystore.

[gemini-code-assist]

Summary of Changes

Hello @suryasoma, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request transitions the application's certificate trust mechanism from relying on the google-java-api-client's default GoogleUtils.getCertificateTrustStore() to using a locally managed google.p12 keystore. This change addresses the absence of the Certigna CA certificate in the default trust store, which is crucial for TPC functionality, and aligns with the google-java-api-client team's guidance to move away from their provided keystore.

Highlights

• Local Keystore Adoption: Replaced the reliance on GoogleUtils.getCertificateTrustStore() with a locally managed google.p12 keystore for certificate trust.
• Certigna CA Certificate Inclusion: The local google.p12 file now includes the Certigna CA certificate, which is essential for TPC functionality.
• Maven Resource Configuration: Updated pom.xml to correctly handle the google.p12 file as a resource, specifically excluding .p12 files from filtering during the build process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a local google.p12 keystore to use a custom certificate. The changes in pom.xml to handle this binary file are correct. However, in HttpTransportFactory.java, the code to load the keystore introduces a resource leak because the InputStream is not closed. I've provided a comment with a suggested fix that uses a try-with-resources statement to ensure the stream is properly closed and also handles the case where the keystore file might not be found, preventing a potential NullPointerException.

[suryasoma]

/gcbrun

[suryasoma]

/gcbrun