Added support for Tokenlist columns#2144
Conversation
|
R: @atask-g |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2144 +/- ##
============================================
+ Coverage 46.72% 46.75% +0.03%
- Complexity 3978 3980 +2
============================================
Files 872 873 +1
Lines 51687 51879 +192
Branches 5402 5430 +28
============================================
+ Hits 24151 24257 +106
- Misses 25818 25897 +79
- Partials 1718 1725 +7
|
|
Looks great! Can you also also add a pg specific test similar to searchIndexes() to InformationSchemaScannerIT.java? Also, consider adding a test to DdlTest.java similar to testSearchIndex() which should improve the code coverage stats. |
|
@atask-g, as discussed offline - will follow up with these tests in the next PR once the rest of the changes are also done so it will help to get comprehensive coverage. Thanks for the review. |
darshan-sj
left a comment
There was a problem hiding this comment.
Looks good.
You will need to raise a PR in apache/beam also similar to this apache/beam#32038
v1/src/main/java/com/google/cloud/teleport/spanner/ddl/InformationSchemaScanner.java
Show resolved
Hide resolved
|
Please sync the change to Beam's SpannerIO : https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java LocalSpannerIO does not admit changes that not already in Beam's SpannerIO, and is going to be teardown #1429 will affect part of the functionality added in this PR |
This PR supports the following for PG dialect:
Did manual testing by creating a test database and running the Cloud_Spanner_to_GCS_Avro template to export and then imported successfully into a new database using a locally built GCS_Avro_to_Cloud_Spanner. The imported database had the TOKENLIST columns along with Hidden attributes.