feat: Remove migration_shard_id check from AssignShardIdFn#2467
Merged
manitgupta merged 4 commits intoGoogleCloudPlatform:mainfrom Jun 18, 2025
Merged
feat: Remove migration_shard_id check from AssignShardIdFn#2467manitgupta merged 4 commits intoGoogleCloudPlatform:mainfrom
manitgupta merged 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
============================================
- Coverage 49.61% 49.59% -0.02%
- Complexity 4803 5153 +350
============================================
Files 941 941
Lines 57665 57658 -7
Branches 6235 6233 -2
============================================
- Hits 28609 28597 -12
- Misses 27011 27017 +6
+ Partials 2045 2044 -1
🚀 New features to boost your workflow:
|
manitgupta
requested review from
bharadwaj-aditya,
pratickchokhani and
rohitwali
manitgupta
force-pushed
the
rev-repl-shard
branch
from
697b479 to
e115eb9
Compare
...ourcedb/src/main/java/com/google/cloud/teleport/v2/templates/transforms/AssignShardIdFn.java
Show resolved
Hide resolved
manitgupta
dismissed stale reviews from bharadwaj-aditya and shreyakhajanchi
via
d6a976a
MnkyGns
pushed a commit
to MnkyGns/DataflowTemplates
that referenced
this pull request
Feb 12, 2026
…udPlatform#2467) * Remove shardIdColumn check from AssignShardId DoFn * Fix mutation * Add TODO comment * Spotless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.