Skip to content

move FileBasedDeadLetterQueueReconsumerTest.java to v2/common#2477

Merged
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
liferoad:move-filedlq-test
Jun 25, 2025
Merged

move FileBasedDeadLetterQueueReconsumerTest.java to v2/common#2477
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
liferoad:move-filedlq-test

Conversation

@liferoad
Copy link
Copy Markdown
Contributor

@liferoad liferoad commented Jun 22, 2025

mvn test -Dtest=com.google.cloud.teleport.v2.cdc.dlq.FileBasedDeadLetterQueueReconsumerTest -pl v2/common

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.60%. Comparing base (43be033) to head (af59297).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2477      +/-   ##
============================================
- Coverage     49.62%   49.60%   -0.03%     
- Complexity     4808     5157     +349     
============================================
  Files           941      941              
  Lines         57661    57661              
  Branches       6233     6233              
============================================
- Hits          28614    28601      -13     
- Misses        27007    27017      +10     
- Partials       2040     2043       +3     
Components Coverage Δ
spanner-templates 69.89% <ø> (-0.06%) ⬇️
spanner-import-export 68.48% <ø> (-0.16%) ⬇️
spanner-live-forward-migration 78.77% <ø> (ø)
spanner-live-reverse-replication 77.36% <ø> (ø)
spanner-bulk-migration 87.89% <ø> (ø)

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@liferoad liferoad changed the title move FileBasedDeadLetterQueueReconsumer.java to v2/common move FileBasedDeadLetterQueueReconsumerTest.java to v2/common Jun 25, 2025
@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Jun 25, 2025

Shall we change the package name to com.google.cloud.teleport.v2.common as well?

@liferoad
Copy link
Copy Markdown
Contributor Author

Shall we change the package name to com.google.cloud.teleport.v2.common as well?

I think com.google.cloud.teleport.v2.cdc.dlq is good.

@liferoad liferoad merged commit 37b9416 into GoogleCloudPlatform:main Jun 25, 2025
41 of 44 checks passed
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants