Skip to content

Reverse replication overrides support#2478

Draft
Deep1998 wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
Deep1998:rev-refactor
Draft

Reverse replication overrides support#2478
Deep1998 wants to merge 6 commits intoGoogleCloudPlatform:mainfrom
Deep1998:rev-refactor

Conversation

@Deep1998
Copy link
Copy Markdown
Contributor

@Deep1998 Deep1998 commented Jun 22, 2025

Reverse replication overrides

  • Support Source ddls
  • Refactor to not use session file for anytohing other than schema mapping/use sourceddl for type info
  • Swap sessino based mapper with schemamapper
  • add overrides support

@Deep1998 Deep1998 force-pushed the rev-refactor branch 3 times, most recently from a31684f to 454f3a4 Compare June 24, 2025 09:48
@Deep1998 Deep1998 force-pushed the rev-refactor branch 2 times, most recently from 3e09e26 to d468427 Compare July 2, 2025 08:50
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2025

Codecov Report

❌ Patch coverage is 76.49573% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.73%. Comparing base (1c0eb5c) to head (086bc8d).
⚠️ Report is 447 commits behind head on main.

Files with missing lines Patch % Lines
...cloud/teleport/v2/templates/SpannerToSourceDb.java 0.00% 56 Missing ⚠️
...eport/v2/spanner/migrations/utils/SchemaUtils.java 88.34% 6 Missing and 6 partials ⚠️
...ates/dbutils/processor/SourceProcessorFactory.java 0.00% 11 Missing ⚠️
...2/templates/dbutils/dml/CassandraDMLGenerator.java 88.13% 2 Missing and 5 partials ⚠️
...anner/sourceddl/MySqlInformationSchemaScanner.java 86.48% 2 Missing and 3 partials ⚠️
...r/sourceddl/CassandraInformationSchemaScanner.java 92.15% 2 Missing and 2 partials ⚠️
...eport/v2/templates/transforms/AssignShardIdFn.java 69.23% 3 Missing and 1 partial ⚠️
...rt/v2/templates/dbutils/dml/MySQLDMLGenerator.java 94.11% 0 Missing and 3 partials ⚠️
...eleport/v2/templates/utils/ShardIdFetcherImpl.java 66.66% 2 Missing and 1 partial ⚠️
.../spanner/migrations/schema/SessionBasedMapper.java 50.00% 2 Missing ⚠️
... and 2 more

❌ Your patch check has failed because the patch coverage (76.49%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2478      +/-   ##
============================================
+ Coverage     49.62%   49.73%   +0.11%     
- Complexity     4814     5162     +348     
============================================
  Files           942      949       +7     
  Lines         57751    58034     +283     
  Branches       6241     6281      +40     
============================================
+ Hits          28659    28865     +206     
- Misses        27049    27115      +66     
- Partials       2043     2054      +11     
Components Coverage Δ
spanner-templates 69.98% <76.49%> (+0.03%) ⬆️
spanner-import-export 68.62% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 79.36% <90.94%> (+0.57%) ⬆️
spanner-live-reverse-replication 77.09% <76.49%> (-0.19%) ⬇️
spanner-bulk-migration 87.97% <90.94%> (+0.07%) ⬆️
Files with missing lines Coverage Δ
...m/google/cloud/teleport/v2/spanner/ddl/Column.java 58.57% <100.00%> (+0.24%) ⬆️
.../teleport/v2/spanner/migrations/schema/Schema.java 90.47% <100.00%> (+0.31%) ⬆️
...rceddl/AbstractSourceInformationSchemaScanner.java 100.00% <100.00%> (ø)
...ud/teleport/v2/spanner/sourceddl/SourceColumn.java 100.00% <100.00%> (ø)
...eport/v2/spanner/sourceddl/SourceDatabaseType.java 100.00% <100.00%> (ø)
...ud/teleport/v2/spanner/sourceddl/SourceSchema.java 100.00% <100.00%> (ø)
...oud/teleport/v2/spanner/sourceddl/SourceTable.java 100.00% <100.00%> (ø)
...plates/dbutils/processor/InputRecordProcessor.java 86.44% <100.00%> (-1.28%) ⬇️
...leport/v2/templates/transforms/SourceWriterFn.java 85.34% <100.00%> (+0.12%) ⬆️
...t/v2/templates/utils/ShardingLogicImplFetcher.java 58.69% <100.00%> (ø)
... and 12 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Deep1998 Deep1998 force-pushed the rev-refactor branch 5 times, most recently from 109c083 to 4194646 Compare July 7, 2025 19:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2026

This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant