Refactor template to avoid using session file for type info#2529
Merged
Deep1998 merged 4 commits intoGoogleCloudPlatform:mainfrom Jul 21, 2025
Merged
Refactor template to avoid using session file for type info#2529Deep1998 merged 4 commits intoGoogleCloudPlatform:mainfrom
Deep1998 merged 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
49e10db to
78e6291
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
============================================
- Coverage 49.73% 49.71% -0.03%
- Complexity 4822 5179 +357
============================================
Files 948 948
Lines 57938 58038 +100
Branches 6259 6275 +16
============================================
+ Hits 28818 28853 +35
- Misses 27070 27123 +53
- Partials 2050 2062 +12
🚀 New features to boost your workflow:
|
7ce8030 to
6cd4f20
Compare
...-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
...nner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDb.java
Outdated
Show resolved
Hide resolved
rohitwali
reviewed
Jul 18, 2025
...-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
...-common/src/main/java/com/google/cloud/teleport/v2/spanner/migrations/utils/SchemaUtils.java
Outdated
Show resolved
Hide resolved
...nner-to-sourcedb/src/main/java/com/google/cloud/teleport/v2/templates/SpannerToSourceDb.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraDMLGenerator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraDMLGenerator.java
Show resolved
Hide resolved
bharadwaj-aditya
requested changes
Jul 21, 2025
...cedb/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/MySQLDMLGenerator.java
Show resolved
Hide resolved
...cedb/src/main/java/com/google/cloud/teleport/v2/templates/dbutils/dml/MySQLDMLGenerator.java
Show resolved
Hide resolved
bharadwaj-aditya
approved these changes
Jul 21, 2025
Contributor
bharadwaj-aditya
left a comment
There was a problem hiding this comment.
Approving as an intermediate PR before the interface changes are merged to simplify this code.
MnkyGns
pushed a commit
to MnkyGns/DataflowTemplates
that referenced
this pull request
Feb 12, 2026
…oudPlatform#2529) * Use tmp cql session builder * Refactor code to avoid session file for anything other than name mappings * Rebase onto sourceddl branch with resolved comments * Move schema utils to test folder and resolve comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the reverse template to avoid using session file for anything other than table/column name-mappings. It instead relies of the Ddl and SourceDdl object for schema specific info. This refactoring is necessary to introduce the schemamapper and henceforth, overrides.