Skip to content

fix parent project in BigQueryToParquet#2530

Merged
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
stankiewicz:fix_bq_project
Jul 12, 2025
Merged

fix parent project in BigQueryToParquet#2530
liferoad merged 1 commit intoGoogleCloudPlatform:mainfrom
stankiewicz:fix_bq_project

Conversation

@stankiewicz
Copy link
Copy Markdown
Contributor

fix parent project in BigQueryToParquet - this should be transparent change as BQIO is following same logic, it was strange that for schema pulling, pipeline is using dataset's project, while for reading it is following options. now it will be aligned.

#2489

…change as BQIO is following same logic, it was strange that for schema pulling, pipeline is using dataset's project, while for reading it is following options. now it will be aligned.
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.61%. Comparing base (47b6f87) to head (ddb0192).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
...cloud/teleport/v2/templates/BigQueryToParquet.java 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2530      +/-   ##
============================================
- Coverage     49.87%   49.61%   -0.26%     
- Complexity     4729     4813      +84     
============================================
  Files           931      942      +11     
  Lines         56525    57755    +1230     
  Branches       6134     6242     +108     
============================================
+ Hits          28193    28658     +465     
- Misses        26315    27052     +737     
- Partials       2017     2045      +28     
Components Coverage Δ
spanner-templates 69.93% <ø> (-0.61%) ⬇️
spanner-import-export 68.62% <ø> (+0.13%) ⬆️
spanner-live-forward-migration 78.79% <ø> (+0.11%) ⬆️
spanner-live-reverse-replication 77.27% <ø> (-3.34%) ⬇️
spanner-bulk-migration 87.89% <ø> (+0.09%) ⬆️
Files with missing lines Coverage Δ
...cloud/teleport/v2/templates/BigQueryToParquet.java 2.98% <12.50%> (+1.39%) ⬆️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stankiewicz
Copy link
Copy Markdown
Contributor Author

@liferoad would you be able to review? thank you

@liferoad liferoad added the improvement Making existing code better label Jul 12, 2025
@liferoad liferoad merged commit 3065504 into GoogleCloudPlatform:main Jul 12, 2025
14 of 16 checks passed
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
…change as BQIO is following same logic, it was strange that for schema pulling, pipeline is using dataset's project, while for reading it is following options. now it will be aligned. (GoogleCloudPlatform#2530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants