Apply GCP Application Default authentication when using a Managed Service for Apache Kafka cluster.#2925
Conversation
Summary of ChangesHello @fozzie15, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Google's Managed Service for Apache Kafka within the streaming data generator. The core change involves dynamically applying GCP Application Default Credentials when the Kafka bootstrap server URL matches a pattern indicative of a Managed Kafka instance. This ensures proper authentication and enables the data generator to seamlessly interact with these managed services. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
============================================
- Coverage 50.06% 50.03% -0.03%
- Complexity 4967 4971 +4
============================================
Files 967 967
Lines 59292 59331 +39
Branches 6440 6449 +9
============================================
+ Hits 29687 29689 +2
- Misses 27502 27537 +35
- Partials 2103 2105 +2
🚀 New features to boost your workflow:
|
…a Managed Service for Apache Kafka cluster
8bbf84d to
f6abe98
Compare
...rc/main/java/com/google/cloud/teleport/v2/transforms/StreamingDataGeneratorWriteToKafka.java
Outdated
Show resolved
Hide resolved
…vice for Apache Kafka cluster. (#2925) * Add logic to apply GCP Application Default authentication when using a Managed Service for Apache Kafka cluster * Tighten the regex for better matching on google clusters.
…vice for Apache Kafka cluster. (GoogleCloudPlatform#2925) * Add logic to apply GCP Application Default authentication when using a Managed Service for Apache Kafka cluster * Tighten the regex for better matching on google clusters.
This change allows the streaming data generator to be used in conjunction with Google's Managed Service for Apache Kafka.
Due to the lack of ability to create UTs/ITs which create and utilize Managed Service resources and the existing flakiness of the kafka IT, this was tested manually. 4 tests were conducted:
These were conducted by modifying the existing Kafka Integration test to utilize these resources as necessary. These cases all pass, and I observed data moving through both kafka clusters.