Skip to content

Add IcebergResourceManager#2985

Merged
Abacn merged 7 commits intoGoogleCloudPlatform:mainfrom
tarun-google:iceberg_it
Nov 17, 2025
Merged

Add IcebergResourceManager#2985
Abacn merged 7 commits intoGoogleCloudPlatform:mainfrom
tarun-google:iceberg_it

Conversation

@tarun-google
Copy link
Contributor

Adding Basic version of IcebergResourceManager that can be utilized with tests. This should cover all the use cases. In the next PR with JDBCToIceberg i look to improve this if more cases are found.

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 89.79592% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.24%. Comparing base (59d8c15) to head (25233f2).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ud/teleport/it/iceberg/IcebergResourceManager.java 89.79% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2985    +/-   ##
==========================================
  Coverage     50.23%   50.24%            
- Complexity     5001     5015    +14     
==========================================
  Files           966      967     +1     
  Lines         59157    59261   +104     
  Branches       6445     6458    +13     
==========================================
+ Hits          29719    29775    +56     
- Misses        27334    27378    +44     
- Partials       2104     2108     +4     
Components Coverage Δ
spanner-templates 70.41% <ø> (-0.04%) ⬇️
spanner-import-export 68.93% <ø> (-0.05%) ⬇️
spanner-live-forward-migration 79.69% <ø> (ø)
spanner-live-reverse-replication 77.03% <ø> (-0.05%) ⬇️
spanner-bulk-migration 88.33% <ø> (ø)
Files with missing lines Coverage Δ
...ud/teleport/it/iceberg/IcebergResourceManager.java 89.79% <89.79%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tarun-google tarun-google marked this pull request as ready for review November 14, 2025 01:08
@derrickaw derrickaw added addition New feature or request improvement Making existing code better labels Nov 14, 2025
derrickaw
derrickaw previously approved these changes Nov 14, 2025
@Abacn Abacn merged commit b81289b into GoogleCloudPlatform:main Nov 17, 2025
14 checks passed
aasthabharill pushed a commit that referenced this pull request Dec 10, 2025
* Add IcebergResourceManager

* Add IcebergResource Manager for IT

* Fix Testcase

* Order fields

* Apply spotless

* Add Unit tests

* Apply Spotless
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
* Add IcebergResourceManager

* Add IcebergResource Manager for IT

* Fix Testcase

* Order fields

* Apply spotless

* Add Unit tests

* Apply Spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request improvement Making existing code better size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants