Add support for year as a primary key#3059
Merged
VardhanThigle merged 5 commits intoGoogleCloudPlatform:mainfrom Dec 9, 2025
Merged
Add support for year as a primary key#3059VardhanThigle merged 5 commits intoGoogleCloudPlatform:mainfrom
year as a primary key#3059VardhanThigle merged 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
Summary of ChangesHello @gpalanisamyYopp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the 'sourcedb-to-spanner' migration tool by adding comprehensive support for the MySQL 'YEAR' data type. It establishes the necessary mapping for 'YEAR' to a numeric type during schema discovery and migration to Spanner, complemented by new test cases to ensure accurate data type conversion and integrity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
v2/sourcedb-to-spanner/src/test/resources/DataTypesIT/mysql-data-types.sql
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
============================================
+ Coverage 50.42% 55.67% +5.24%
+ Complexity 5022 1614 -3408
============================================
Files 969 468 -501
Lines 59548 26352 -33196
Branches 6493 2772 -3721
============================================
- Hits 30030 14672 -15358
+ Misses 27397 10789 -16608
+ Partials 2121 891 -1230
🚀 New features to boost your workflow:
|
Contributor
|
Please fix spotless. I will re-trigger the workflows after that's done. |
NicolasRicheYopp
approved these changes
Dec 8, 2025
…gpalanisamyYopp/DataflowTemplates into source-to-spanner-mysql-year-pk
VardhanThigle
approved these changes
Dec 8, 2025
Contributor
|
Thanks for fixing spotless.Looks good to me. Waiting for ITs to pass before merge. |
gpalanisamyYopp
changed the title
Contributor
|
Test Failure for too many Dataflow requests. Rerunning the tests.... |
VardhanThigle
changed the title
year as a primary key
VardhanThigle
merged commit 301cd41
into
GoogleCloudPlatform:main
20 of 21 checks passed
aasthabharill
pushed a commit
that referenced
this pull request
Dec 10, 2025
* add YEAR mapping * orrect expectedData for YEAR column * fix spotless error
aasthabharill
pushed a commit
to aasthabharill/DataflowTemplates
that referenced
this pull request
Dec 15, 2025
* add YEAR mapping * orrect expectedData for YEAR column * fix spotless error
aasthabharill
pushed a commit
to aasthabharill/DataflowTemplates
that referenced
this pull request
Dec 17, 2025
* add YEAR mapping * orrect expectedData for YEAR column * fix spotless error
MnkyGns
pushed a commit
to MnkyGns/DataflowTemplates
that referenced
this pull request
Feb 12, 2026
* add YEAR mapping * orrect expectedData for YEAR column * fix spotless error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.