Skip to content

Reenable cache for Python/Xlang/Yaml templates#3077

Merged
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Abacn:reenablecache
Dec 8, 2025
Merged

Reenable cache for Python/Xlang/Yaml templates#3077
Abacn merged 1 commit intoGoogleCloudPlatform:mainfrom
Abacn:reenablecache

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Dec 8, 2025

@gemini-code-assist
Copy link

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing the build process for Python, Xlang, and Yaml templates by re-enabling and refining the Kaniko caching strategy. The core change involves activating the build cache and implementing a weekly rotating cache directory. This approach is designed to enhance build speed by reusing image layers while proactively addressing potential cache staleness, thereby improving the overall reliability and performance of template staging.

Highlights

  • Re-enabled Kaniko Caching: Kaniko caching has been re-enabled for Python, Xlang, and Yaml templates to improve build performance and efficiency.
  • Weekly Rotating Cache Directory: A new mechanism has been introduced to create a weekly rotating cache directory, aiming to mitigate issues related to cache invalidation and ensure fresh builds when necessary.
  • Code Cleanup: Previously commented-out lines related to cache configuration have been removed, cleaning up the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.40%. Comparing base (efb574a) to head (e4672d4).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...loud/teleport/plugin/maven/TemplatesStageMojo.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3077      +/-   ##
============================================
+ Coverage     50.26%   50.40%   +0.14%     
+ Complexity     5024     5019       -5     
============================================
  Files           967      970       +3     
  Lines         59271    59585     +314     
  Branches       6459     6499      +40     
============================================
+ Hits          29794    30036     +242     
- Misses        27376    27425      +49     
- Partials       2101     2124      +23     
Components Coverage Δ
spanner-templates 70.59% <87.37%> (+0.13%) ⬆️
spanner-import-export 68.85% <ø> (-0.17%) ⬇️
spanner-live-forward-migration 80.03% <87.37%> (+0.34%) ⬆️
spanner-live-reverse-replication 77.47% <87.37%> (+0.36%) ⬆️
spanner-bulk-migration 88.25% <87.37%> (-0.09%) ⬇️
Files with missing lines Coverage Δ
...loud/teleport/plugin/maven/TemplatesStageMojo.java 8.22% <0.00%> (-0.10%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn
Copy link
Contributor Author

Abacn commented Dec 8, 2025

R: @derrickaw

@Abacn Abacn merged commit 08e1a2c into GoogleCloudPlatform:main Dec 8, 2025
15 of 17 checks passed
@Abacn Abacn deleted the reenablecache branch December 8, 2025 20:18
aasthabharill pushed a commit to aasthabharill/DataflowTemplates that referenced this pull request Dec 15, 2025
aasthabharill pushed a commit to aasthabharill/DataflowTemplates that referenced this pull request Dec 17, 2025
MnkyGns pushed a commit to MnkyGns/DataflowTemplates that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants